Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1303)

Unified Diff: dashboard/dashboard/pinpoint/models/quest/find_isolate.py

Issue 3019553002: [pinpoint] Gerrit patch support. (Closed)
Patch Set: Example URL Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dashboard/dashboard/pinpoint/models/quest/find_isolate.py
diff --git a/dashboard/dashboard/pinpoint/models/quest/find_isolate.py b/dashboard/dashboard/pinpoint/models/quest/find_isolate.py
index 295a0d7ef8dc725e54f7f58a79a4f44354ddb31c..8f1d983a5e31464dbc55aedf32711c20efb5d160 100644
--- a/dashboard/dashboard/pinpoint/models/quest/find_isolate.py
+++ b/dashboard/dashboard/pinpoint/models/quest/find_isolate.py
@@ -151,14 +151,7 @@ def _RequestBuild(builder_name, change):
}
if change.patch:
- # TODO: Support Gerrit.
- # https://github.com/catapult-project/catapult/issues/3599
- parameters['properties'].update({
- 'patch_storage': 'rietveld',
- 'rietveld': change.patch.server,
- 'issue': change.patch.issue,
- 'patchset': change.patch.patchset,
- })
+ parameters['properties'].update(change.patch.BuildParameters())
# TODO: Look up Buildbucket bucket from builder_name.
return buildbucket_service.Put(BUCKET, parameters)

Powered by Google App Engine
This is Rietveld 408576698