Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: dashboard/dashboard/pinpoint/models/quest/find_isolate.py

Issue 3019553002: [pinpoint] Gerrit patch support. (Closed)
Patch Set: Example URL Created 3 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from dashboard.pinpoint.models import isolate 5 from dashboard.pinpoint.models import isolate
6 from dashboard.pinpoint.models.quest import execution 6 from dashboard.pinpoint.models.quest import execution
7 from dashboard.pinpoint.models.quest import quest 7 from dashboard.pinpoint.models.quest import quest
8 from dashboard.services import buildbucket_service 8 from dashboard.services import buildbucket_service
9 9
10 10
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 parameters = { 144 parameters = {
145 'builder_name': builder_name, 145 'builder_name': builder_name,
146 'properties': { 146 'properties': {
147 'clobber': True, 147 'clobber': True,
148 'parent_got_revision': change.base_commit.git_hash, 148 'parent_got_revision': change.base_commit.git_hash,
149 'deps_revision_overrides': deps_overrides, 149 'deps_revision_overrides': deps_overrides,
150 }, 150 },
151 } 151 }
152 152
153 if change.patch: 153 if change.patch:
154 # TODO: Support Gerrit. 154 parameters['properties'].update(change.patch.BuildParameters())
155 # https://github.com/catapult-project/catapult/issues/3599
156 parameters['properties'].update({
157 'patch_storage': 'rietveld',
158 'rietveld': change.patch.server,
159 'issue': change.patch.issue,
160 'patchset': change.patch.patchset,
161 })
162 155
163 # TODO: Look up Buildbucket bucket from builder_name. 156 # TODO: Look up Buildbucket bucket from builder_name.
164 return buildbucket_service.Put(BUCKET, parameters) 157 return buildbucket_service.Put(BUCKET, parameters)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698