[pinpoint] Gerrit patch support.

dashboard/dashboard/pinpoint/models/quest/find_isolate_test.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import unittest
 
 import mock
 
 from google.appengine.ext import ndb
 from google.appengine.ext import testbed
@@ skipping 95 matching lines @@
 
   def testUnknownBuilder(self):
     with self.assertRaises(NotImplementedError):
       find_isolate.FindIsolate('Unix Perf', 'telemetry_perf_tests')
 
 
 @mock.patch('dashboard.services.buildbucket_service.GetJobStatus')
 @mock.patch('dashboard.services.buildbucket_service.Put')
 class BuildTest(_FindIsolateTest):
 
-  def testBuildLifecycle(self, put, get_job_status):
+  @mock.patch.object(change_module.GerritPatch, 'BuildParameters')
+  def testBuildLifecycle(self, build_parameters, put, get_job_status):
     change = change_module.Change(
         (change_module.Commit('src', 'base git hash'),
          change_module.Commit('v8', 'dep git hash')),
-        patch=change_module.Patch('https://example.org', 2565263002, 20001))
+        patch=change_module.GerritPatch('https://example.org', 672011, '2f0d'))
     quest = find_isolate.FindIsolate('Mac Pro Perf', 'telemetry_perf_tests')
     execution = quest.Start(change)
 
     # Request a build.
+    build_parameters.return_value = {'patch_storage': 'gerrit'}
     put.return_value = {'build': {'id': 'build_id'}}
     execution.Poll()
 
     self.assertFalse(execution.completed)
     put.assert_called_once_with(find_isolate.BUCKET, {
         'builder_name': 'Mac Builder',
         'properties': {
             'clobber': True,
             'parent_got_revision': 'base git hash',
             'deps_revision_overrides': {
                 'https://chromium.googlesource.com/v8/v8': 'dep git hash',
             },
-            'patch_storage': 'rietveld',
-            'rietveld': 'https://example.org',
-            'issue': 2565263002,
-            'patchset': 20001,
+            'patch_storage': 'gerrit',
         }
     })
 
     # Check build status.
     get_job_status.return_value = {'build': {'status': 'STARTED'}}
     execution.Poll()
 
     self.assertFalse(execution.completed)
     get_job_status.assert_called_once_with('build_id')
 
@@ skipping 35 matching lines @@
     isolate.Put((('Mac Builder', change,
                   'telemetry_perf_tests', 'isolate git hash'),))
     execution_1.Poll()
     execution_2.Poll()
 
     self.assertExecutionSuccess(execution_1)
     self.assertExecutionSuccess(execution_2)
 
   def testBuildFailure(self, put, get_job_status):
     change = change_module.Change(
-        (change_module.Commit('src', 'base git hash'),
-         change_module.Commit('v8', 'dep git hash')),
-        patch=change_module.Patch('https://example.org', 2565263002, 20001))
+        (change_module.Commit('src', 'base git hash'),))
     quest = find_isolate.FindIsolate('Mac Pro Perf', 'telemetry_perf_tests')
     execution = quest.Start(change)
 
     # Request a build.
     put.return_value = {'build': {'id': 'build_id'}}
     execution.Poll()
 
     # Check build status.
     get_job_status.return_value = {
         'build': {
             'status': 'COMPLETED',
             'result': 'FAILURE',
             'failure_reason': 'BUILD_FAILURE',
         }
     }
     execution.Poll()
 
     self.assertExecutionFailure(execution, find_isolate.BuildError)
 
   def testBuildCanceled(self, put, get_job_status):
     change = change_module.Change(
-        (change_module.Commit('src', 'base git hash'),
-         change_module.Commit('v8', 'dep git hash')),
-        patch=change_module.Patch('https://example.org', 2565263002, 20001))
+        (change_module.Commit('src', 'base git hash'),))
     quest = find_isolate.FindIsolate('Mac Pro Perf', 'telemetry_perf_tests')
     execution = quest.Start(change)
 
     # Request a build.
     put.return_value = {'build': {'id': 'build_id'}}
     execution.Poll()
 
     # Check build status.
     get_job_status.return_value = {
         'build': {
             'status': 'COMPLETED',
             'result': 'CANCELED',
             'cancelation_reason': 'TIMEOUT',
         }
     }
     execution.Poll()
 
     self.assertExecutionFailure(execution, find_isolate.BuildError)
 
   def testBuildSucceededButIsolateIsMissing(self, put, get_job_status):
     change = change_module.Change(
-        (change_module.Commit('src', 'base git hash'),
-         change_module.Commit('v8', 'dep git hash')),
-        patch=change_module.Patch('https://example.org', 2565263002, 20001))
+        (change_module.Commit('src', 'base git hash'),))
     quest = find_isolate.FindIsolate('Mac Pro Perf', 'telemetry_perf_tests')
     execution = quest.Start(change)
 
     # Request a build.
     put.return_value = {'build': {'id': 'build_id'}}
     execution.Poll()
 
     # Check build status.
     get_job_status.return_value = {
         'build': {
             'status': 'COMPLETED',
             'result': 'SUCCESS',
         }
     }
     execution.Poll()
 
     self.assertExecutionFailure(execution, find_isolate.BuildError)