Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 3017633002: [pinpoint] Move _previous_builds from the Execution class to the Quest instance. (Closed)

Created:
3 years, 2 months ago by dtu
Modified:
3 years, 2 months ago
Reviewers:
perezju, shatch, sullivan
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[pinpoint] Move _previous_builds from the Execution class to the Quest instance. BUG=catapult:#3917 Review-Url: https://chromiumcodereview.appspot.com/3017633002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/32020f518fc6d8a9e714c9cf13897ff0a944996f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M dashboard/dashboard/pinpoint/models/quest/find_isolate.py View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
dtu
3 years, 2 months ago (2017-09-26 02:49:33 UTC) #2
perezju
lgtm definitely looks better than having it stashed in the class as before
3 years, 2 months ago (2017-09-26 09:24:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3017633002/1
3 years, 2 months ago (2017-09-26 20:00:47 UTC) #5
commit-bot: I haz the power
3 years, 2 months ago (2017-09-26 20:33:05 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698