Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 301573002: Fix WeakPtrFactory member order in net/spdy and net/dns (Closed)

Created:
6 years, 7 months ago by Nikhil
Modified:
6 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix WeakPtrFactory member order Fix WeakPtrFactory member order in net/spdy/ & net/dns/ BUG=303818 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273022

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -37 lines) Patch
M net/dns/dns_config_service_posix.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M net/dns/host_resolver_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M net/dns/host_resolver_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/spdy/spdy_http_stream.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_http_stream.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/spdy_proxy_client_socket.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_proxy_client_socket.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_session.h View 4 chunks +8 lines, -7 lines 0 comments Download
M net/spdy/spdy_session.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/spdy_stream.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_stream.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_websocket_stream.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/spdy/spdy_websocket_stream.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nikhil
PTAL. Thanks!
6 years, 7 months ago (2014-05-26 13:20:50 UTC) #1
Nikhil
Adding Ryan. PTAL. Thanks!
6 years, 7 months ago (2014-05-27 06:11:16 UTC) #2
Ryan Sleevi
lgtm
6 years, 7 months ago (2014-05-27 16:25:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/n.bansal@samsung.com/301573002/1
6 years, 7 months ago (2014-05-27 16:26:36 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 7 months ago (2014-05-27 20:02:43 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-27 20:55:22 UTC) #6
Message was sent while issue was closed.
Change committed as 273022

Powered by Google App Engine
This is Rietveld 408576698