Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Side by Side Diff: net/spdy/spdy_http_stream.h

Issue 301573002: Fix WeakPtrFactory member order in net/spdy and net/dns (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/dns/host_resolver_impl.cc ('k') | net/spdy/spdy_http_stream.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_SPDY_SPDY_HTTP_STREAM_H_ 5 #ifndef NET_SPDY_SPDY_HTTP_STREAM_H_
6 #define NET_SPDY_SPDY_HTTP_STREAM_H_ 6 #define NET_SPDY_SPDY_HTTP_STREAM_H_
7 7
8 #include <list> 8 #include <list>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 102
103 // Call the user callback. 103 // Call the user callback.
104 void DoCallback(int rv); 104 void DoCallback(int rv);
105 105
106 void ScheduleBufferedReadCallback(); 106 void ScheduleBufferedReadCallback();
107 107
108 // Returns true if the callback is invoked. 108 // Returns true if the callback is invoked.
109 bool DoBufferedReadCallback(); 109 bool DoBufferedReadCallback();
110 bool ShouldWaitForMoreBufferedData() const; 110 bool ShouldWaitForMoreBufferedData() const;
111 111
112 base::WeakPtrFactory<SpdyHttpStream> weak_factory_;
113
114 const base::WeakPtr<SpdySession> spdy_session_; 112 const base::WeakPtr<SpdySession> spdy_session_;
115 bool is_reused_; 113 bool is_reused_;
116 SpdyStreamRequest stream_request_; 114 SpdyStreamRequest stream_request_;
117 base::WeakPtr<SpdyStream> stream_; 115 base::WeakPtr<SpdyStream> stream_;
118 116
119 bool stream_closed_; 117 bool stream_closed_;
120 118
121 // Set only when |stream_closed_| is true. 119 // Set only when |stream_closed_| is true.
122 int closed_stream_status_; 120 int closed_stream_status_;
123 SpdyStreamId closed_stream_id_; 121 SpdyStreamId closed_stream_id_;
(...skipping 30 matching lines...) Expand all
154 152
155 // Is there a scheduled read callback pending. 153 // Is there a scheduled read callback pending.
156 bool buffered_read_callback_pending_; 154 bool buffered_read_callback_pending_;
157 // Has more data been received from the network during the wait for the 155 // Has more data been received from the network during the wait for the
158 // scheduled read callback. 156 // scheduled read callback.
159 bool more_read_data_pending_; 157 bool more_read_data_pending_;
160 158
161 // Is this spdy stream direct to the origin server (or to a proxy). 159 // Is this spdy stream direct to the origin server (or to a proxy).
162 bool direct_; 160 bool direct_;
163 161
162 base::WeakPtrFactory<SpdyHttpStream> weak_factory_;
163
164 DISALLOW_COPY_AND_ASSIGN(SpdyHttpStream); 164 DISALLOW_COPY_AND_ASSIGN(SpdyHttpStream);
165 }; 165 };
166 166
167 } // namespace net 167 } // namespace net
168 168
169 #endif // NET_SPDY_SPDY_HTTP_STREAM_H_ 169 #endif // NET_SPDY_SPDY_HTTP_STREAM_H_
OLDNEW
« no previous file with comments | « net/dns/host_resolver_impl.cc ('k') | net/spdy/spdy_http_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698