net/dns/host_resolver_impl.cc - Issue 301573002: Fix WeakPtrFactory member order in net/spdy and net/dns

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/host_resolver_impl.cc

Issue 301573002: Fix WeakPtrFactory member order in net/spdy and net/dns (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/dns/host_resolver_impl.cc

diff --git a/net/dns/host_resolver_impl.cc b/net/dns/host_resolver_impl.cc

index a1ab0e5b9b4f54bf12e65ee4e91e40b1b5a2f160..dd11336d3d16f2625f103409b66d27cf1a1ee134 100644

--- a/net/dns/host_resolver_impl.cc

+++ b/net/dns/host_resolver_impl.cc

@@ -1798,15 +1798,15 @@ HostResolverImpl::HostResolverImpl(

proc_params_(proc_params),

net_log_(net_log),

default_address_family_(ADDRESS_FAMILY_UNSPECIFIED),

- weak_ptr_factory_(this),

- probe_weak_ptr_factory_(this),

received_dns_config_(false),

num_dns_failures_(0),

probe_ipv6_support_(true),

use_local_ipv6_(false),

resolved_known_ipv6_hostname_(false),

additional_resolver_flags_(0),

- fallback_to_proctask_(true) {

+ fallback_to_proctask_(true),

+ weak_ptr_factory_(this),

+ probe_weak_ptr_factory_(this) {

DCHECK_GE(dispatcher_.num_priorities(), static_cast<size_t>(NUM_PRIORITIES));

« no previous file with comments | « net/dns/host_resolver_impl.h ('k') | net/spdy/spdy_http_stream.h » ('j') | no next file with comments »