net/spdy/spdy_stream.cc - Issue 301573002: Fix WeakPtrFactory member order in net/spdy and net/dns

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_stream.cc

Issue 301573002: Fix WeakPtrFactory member order in net/spdy and net/dns (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/spdy/spdy_stream.cc

diff --git a/net/spdy/spdy_stream.cc b/net/spdy/spdy_stream.cc

index 398890593023e29141f4d570dd74b4fc0e78d405..682eb466014794272f1b4789c78a8d9042c4e25a 100644

--- a/net/spdy/spdy_stream.cc

+++ b/net/spdy/spdy_stream.cc

@@ -85,7 +85,6 @@ SpdyStream::SpdyStream(SpdyStreamType type,

int32 initial_recv_window_size,

const BoundNetLog& net_log)

: type_(type),

- weak_ptr_factory_(this),

stream_id_(0),

url_(url),

priority_(priority),

@@ -104,7 +103,8 @@ SpdyStream::SpdyStream(SpdyStreamType type,

raw_received_bytes_(0),

send_bytes_(0),

recv_bytes_(0),

- write_handler_guard_(false) {

+ write_handler_guard_(false),

+ weak_ptr_factory_(this) {

CHECK(type_ == SPDY_BIDIRECTIONAL_STREAM ||

type_ == SPDY_REQUEST_RESPONSE_STREAM ||

type_ == SPDY_PUSH_STREAM);

« no previous file with comments | « net/spdy/spdy_stream.h ('k') | net/spdy/spdy_websocket_stream.h » ('j') | no next file with comments »