Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: net/dns/dns_config_service_posix.cc

Issue 301573002: Fix WeakPtrFactory member order in net/spdy and net/dns (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/dns/host_resolver_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/dns/dns_config_service_posix.cc
diff --git a/net/dns/dns_config_service_posix.cc b/net/dns/dns_config_service_posix.cc
index 0644d4d42947142a935786337a291fbd7e0c3d90..2c298ddedbb8c98ce46a950929eba2616322baa5 100644
--- a/net/dns/dns_config_service_posix.cc
+++ b/net/dns/dns_config_service_posix.cc
@@ -202,8 +202,8 @@ ConfigParsePosixResult ReadDnsConfig(DnsConfig* dns_config) {
class DnsConfigServicePosix::Watcher {
public:
explicit Watcher(DnsConfigServicePosix* service)
- : weak_factory_(this),
- service_(service) {}
+ : service_(service),
+ weak_factory_(this) {}
~Watcher() {}
bool Watch() {
@@ -246,11 +246,12 @@ class DnsConfigServicePosix::Watcher {
service_->OnHostsChanged(!error);
}
- base::WeakPtrFactory<Watcher> weak_factory_;
DnsConfigServicePosix* service_;
DnsConfigWatcher config_watcher_;
base::FilePathWatcher hosts_watcher_;
+ base::WeakPtrFactory<Watcher> weak_factory_;
+
DISALLOW_COPY_AND_ASSIGN(Watcher);
};
« no previous file with comments | « no previous file | net/dns/host_resolver_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698