net/spdy/spdy_stream.h - Issue 301573002: Fix WeakPtrFactory member order in net/spdy and net/dns

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_stream.h

Issue 301573002: Fix WeakPtrFactory member order in net/spdy and net/dns (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/spdy/spdy_stream.h

diff --git a/net/spdy/spdy_stream.h b/net/spdy/spdy_stream.h

index 4e3c61a143e2bc793c27f0bf7ba8fd55e81d9ddc..e107143f9c83f0cfd9fa2f1f0b7e47aea84ad281 100644

--- a/net/spdy/spdy_stream.h

+++ b/net/spdy/spdy_stream.h

@@ -488,8 +488,6 @@ class NET_EXPORT_PRIVATE SpdyStream {

const SpdyStreamType type_;

- base::WeakPtrFactory<SpdyStream> weak_ptr_factory_;

SpdyStreamId stream_id_;

const GURL url_;

const RequestPriority priority_;

@@ -562,6 +560,8 @@ class NET_EXPORT_PRIVATE SpdyStream {

// down.

bool write_handler_guard_;

+ base::WeakPtrFactory<SpdyStream> weak_ptr_factory_;

DISALLOW_COPY_AND_ASSIGN(SpdyStream);

};

« no previous file with comments | « net/spdy/spdy_session.cc ('k') | net/spdy/spdy_stream.cc » ('j') | no next file with comments »