Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2993933002: scheduler ACLs: improve ACL-related error handling in UI and API. (Closed)

Created:
3 years, 4 months ago by tandrii(chromium)
Modified:
3 years, 4 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -30 lines) Patch
M scheduler/appengine/apiservers/scheduler.go View 2 chunks +7 lines, -12 lines 0 comments Download
M scheduler/appengine/apiservers/scheduler_test.go View 2 chunks +6 lines, -2 lines 0 comments Download
M scheduler/appengine/engine/engine.go View 2 chunks +6 lines, -6 lines 0 comments Download
M scheduler/appengine/ui/invocation.go View 1 chunk +6 lines, -6 lines 0 comments Download
M scheduler/appengine/ui/job.go View 1 chunk +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (12 generated)
tandrii(chromium)
ptal
3 years, 4 months ago (2017-08-08 15:44:31 UTC) #7
Vadim Sh.
lgtm
3 years, 4 months ago (2017-08-08 19:06:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2993933002/40001
3 years, 4 months ago (2017-08-08 19:27:15 UTC) #13
commit-bot: I haz the power
3 years, 4 months ago (2017-08-08 19:31:31 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/8041575c0cc31396d49f3662172d6227f5dff7bd

Powered by Google App Engine
This is Rietveld 408576698