Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Unified Diff: scheduler/appengine/apiservers/scheduler_test.go

Issue 2993933002: scheduler ACLs: improve ACL-related error handling in UI and API. (Closed)
Patch Set: rebase Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scheduler/appengine/apiservers/scheduler.go ('k') | scheduler/appengine/engine/engine.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scheduler/appengine/apiservers/scheduler_test.go
diff --git a/scheduler/appengine/apiservers/scheduler_test.go b/scheduler/appengine/apiservers/scheduler_test.go
index 682af72a5be22fe6fdc7582b3aa1c2160e1abda7..a76afe20a1d17c818f65c7684ae7bdd1e63777ea 100644
--- a/scheduler/appengine/apiservers/scheduler_test.go
+++ b/scheduler/appengine/apiservers/scheduler_test.go
@@ -159,7 +159,9 @@ func TestGetInvocationsApi(t *testing.T) {
ss := SchedulerServer{fakeEng, catalog}
Convey("Job not found", func() {
- fakeEng.getVisibleJob = func(JobID string) (*engine.Job, error) { return nil, nil }
+ fakeEng.listVisibleInvocations = func(int, string) ([]*engine.Invocation, string, error) {
+ return nil, "", engine.ErrNoSuchJob
+ }
_, err := ss.GetInvocations(ctx, &scheduler.InvocationsRequest{
JobRef: &scheduler.JobRef{Project: "not", Job: "exists"},
})
@@ -169,7 +171,9 @@ func TestGetInvocationsApi(t *testing.T) {
})
Convey("DS error", func() {
- fakeEng.getVisibleJob = func(JobID string) (*engine.Job, error) { return nil, fmt.Errorf("ds error") }
+ fakeEng.listVisibleInvocations = func(int, string) ([]*engine.Invocation, string, error) {
+ return nil, "", fmt.Errorf("ds error")
+ }
_, err := ss.GetInvocations(ctx, &scheduler.InvocationsRequest{
JobRef: &scheduler.JobRef{Project: "proj", Job: "job"},
})
« no previous file with comments | « scheduler/appengine/apiservers/scheduler.go ('k') | scheduler/appengine/engine/engine.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698