scheduler ACLs: improve ACL-related error handling in UI and API.

scheduler/appengine/apiservers/scheduler.go

 // Copyright 2016 The LUCI Authors.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //      http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 56 matching lines @@
                         State: &scheduler.JobState{
                                 UiStatus: string(presentation.GetPublicStateKind(ej, traits)),
                         },
                         Paused: ej.Paused,
                 }
         }
         return &scheduler.JobsReply{Jobs: jobs, NextCursor: ""}, nil
 }
 
 func (s SchedulerServer) GetInvocations(ctx context.Context, in *scheduler.InvocationsRequest) (*scheduler.InvocationsReply, error) {
-        ejob, err := s.Engine.GetVisibleJob(ctx, getJobId(in.GetJobRef()))
-        if err != nil {
-                return nil, grpc.Errorf(codes.Internal, "internal error: %s", err)
-        }
-        if ejob == nil {
-                return nil, grpc.Errorf(codes.NotFound, "Job does not exist or you have no access")
-        }
-
         pageSize := 50
         if in.PageSize > 0 && int(in.PageSize) < pageSize {
                 pageSize = int(in.PageSize)
         }
 
-        einvs, cursor, err := s.Engine.ListVisibleInvocations(ctx, ejob.JobID, pageSize, in.GetCursor())
-        if err != nil {
+        einvs, cursor, err := s.Engine.ListVisibleInvocations(ctx, getJobId(in.GetJobRef()), pageSize, in.GetCursor())
+        switch {
+        case err == engine.ErrNoSuchJob:
+                return nil, grpc.Errorf(codes.NotFound, "Job does not exist or no access")
+        case err != nil:
                 return nil, grpc.Errorf(codes.Internal, "internal error: %s", err)
         }
         invs := make([]*scheduler.Invocation, len(einvs))
         for i, einv := range einvs {
                 invs[i] = &scheduler.Invocation{
                         InvocationRef: &scheduler.InvocationRef{
                                 JobRef: &scheduler.JobRef{
-                                        Project: ejob.ProjectID,
-                                        Job:     ejob.GetJobName(),
+                                        Project: in.GetJobRef().GetProject(),
+                                        Job:     in.GetJobRef().GetJob(),
                                 },
                                 InvocationId: einv.ID,
                         },
                         StartedTs:      einv.Started.UnixNano() / 1000,
                         TriggeredBy:    string(einv.TriggeredBy),
                         Status:         string(einv.Status),
                         Final:          einv.Status.Final(),
                         ConfigRevision: einv.Revision,
                         ViewUrl:        einv.ViewURL,
                 }
@@ skipping 44 matching lines @@
         case err == engine.ErrNoSuchInvocation:
                 return nil, grpc.Errorf(codes.NotFound, "no such invocation")
         default:
                 return nil, grpc.Errorf(codes.Internal, "internal error: %s", err)
         }
 }
 
 func getJobId(jobRef *scheduler.JobRef) string {
         return jobRef.GetProject() + "/" + jobRef.GetJob()
 }