Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2998623002:
scheduler ACLs: fix ACLs saving upon job config change. (Closed)
|
Created:
3 years, 4 months ago by tandrii(chromium) Modified:
3 years, 4 months ago Reviewers:
Vadim Sh. CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org Target Ref:
refs/heads/master Project:
luci-go Visibility:
Public. |
Descriptionscheduler ACLs: fix ACLs saving upon job config change.
R=vadimsh@chromium.org
BUG=736770
Review-Url: https://codereview.chromium.org/2998623002
Committed: https://github.com/luci/luci-go/commit/23372de1dbe84de8c9d3fccef791341f5fa369fc
Patch Set 1 #Patch Set 2 : more fix #Patch Set 3 : no tests #Patch Set 4 : with tests #Patch Set 5 : re-arrange #Patch Set 6 : fix import order #
Total comments: 3
Messages
Total messages: 34 (27 generated)
The CQ bit was checked by tandrii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tandrii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tandrii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Derp :(
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tandrii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tandrii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tandrii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2998623002/diff/100001/scheduler/appengine/en... File scheduler/appengine/engine/engine.go (right): https://codereview.chromium.org/2998623002/diff/100001/scheduler/appengine/en... scheduler/appengine/engine/engine.go:336: e.Acls.Equal(&other.Acls) && err... I remember reviewing this line. What happened to it?
https://codereview.chromium.org/2998623002/diff/100001/scheduler/appengine/en... File scheduler/appengine/engine/engine.go (right): https://codereview.chromium.org/2998623002/diff/100001/scheduler/appengine/en... scheduler/appengine/engine/engine.go:336: e.Acls.Equal(&other.Acls) && On 2017/08/08 19:11:16, Vadim Sh. wrote: > err... I remember reviewing this line. What happened to it? you've reviewed very similar line below. https://codereview.chromium.org/2998623002/diff/100001/scheduler/appengine/en... scheduler/appengine/engine/engine.go:348: e.Acls.Equal(&def.Acls) && it was this line :)
The CQ bit was checked by tandrii@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1502220016114400,
"parent_rev": "84692af28c1726ba97d84dde6ec5bfb691add08e", "commit_rev":
"23372de1dbe84de8c9d3fccef791341f5fa369fc"}
Message was sent while issue was closed.
Description was changed from ========== scheduler ACLs: fix ACLs saving upon job config change. R=vadimsh@chromium.org BUG=736770 ========== to ========== scheduler ACLs: fix ACLs saving upon job config change. R=vadimsh@chromium.org BUG=736770 Review-Url: https://codereview.chromium.org/2998623002 Committed: https://github.com/luci/luci-go/commit/23372de1dbe84de8c9d3fccef791341f5fa369fc ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as https://github.com/luci/luci-go/commit/23372de1dbe84de8c9d3fccef791341f5fa369fc |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
