scheduler ACLs: improve ACL-related error handling in UI and API.

scheduler/appengine/apiservers/scheduler_test.go

 // Copyright 2017 The LUCI Authors.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //      http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 141 matching lines @@
         t.Parallel()
 
         Convey("Scheduler GetInvocations API works", t, func() {
                 ctx := gaetesting.TestingContext()
                 fakeEng, catalog := newTestEngine()
                 _, err := registerUrlFetcher(catalog)
                 So(err, ShouldBeNil)
                 ss := SchedulerServer{fakeEng, catalog}
 
                 Convey("Job not found", func() {
-                        fakeEng.getVisibleJob = func(JobID string) (*engine.Job, error) { return nil, nil }
+                        fakeEng.listVisibleInvocations = func(int, string) ([]*engine.Invocation, string, error) {
+                                return nil, "", engine.ErrNoSuchJob
+                        }
                         _, err := ss.GetInvocations(ctx, &scheduler.InvocationsRequest{
                                 JobRef: &scheduler.JobRef{Project: "not", Job: "exists"},
                         })
                         s, ok := status.FromError(err)
                         So(ok, ShouldBeTrue)
                         So(s.Code(), ShouldEqual, codes.NotFound)
                 })
 
                 Convey("DS error", func() {
-                        fakeEng.getVisibleJob = func(JobID string) (*engine.Job, error) { return nil, fmt.Errorf("ds error") }
+                        fakeEng.listVisibleInvocations = func(int, string) ([]*engine.Invocation, string, error) {
+                                return nil, "", fmt.Errorf("ds error")
+                        }
                         _, err := ss.GetInvocations(ctx, &scheduler.InvocationsRequest{
                                 JobRef: &scheduler.JobRef{Project: "proj", Job: "job"},
                         })
                         s, ok := status.FromError(err)
                         So(ok, ShouldBeTrue)
                         So(s.Code(), ShouldEqual, codes.Internal)
                 })
 
                 fakeEng.getVisibleJob = func(JobID string) (*engine.Job, error) {
                         return &engine.Job{JobID: "proj/job", ProjectID: "proj"}, nil
@@ skipping 250 matching lines @@
         panic("not implemented")
 }
 
 func (f *fakeEngine) TriggerInvocation(c context.Context, jobID string) (int64, error) {
         panic("not implemented")
 }
 
 func (f *fakeEngine) InternalAPI() engine.EngineInternal {
         panic("not implemented")
 }