Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2989793003: Revert of [Bindings] Create and use V8 context snapshots (Closed)

Created:
3 years, 4 months ago by blundell
Modified:
3 years, 4 months ago
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-bindings_chromium.org, blink-worker-reviews_chromium.org, caseq+blink_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, falken+watch_chromium.org, horo+watch_chromium.org, jam, kinuko+watch, kinuko+worker_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, net-reviews_chromium.org, pfeldman+blink_chromium.org, shimazu+worker_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Bindings] Create and use V8 context snapshots (patchset #22 id:520001 of https://codereview.chromium.org/2841443005/ ) Reason for revert: Causes compile to fail on MSAN because of usage of uninitialized memory: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit_Linux_Trusty_MSAN%2F2265%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout Original issue's description: > Create and use V8 context snapshots. > > This CL does two things. > > 1. In compile time, creates a snapshot file, which consists of V8 contexts. > 2. Creates v8::Context from the snapshot in LocalWindowProxy::CreateContext(). > > We expect this speeds up context creation for 3 times faster on Android. > Detailed information is described in the design doc [1]. > > > [1] Design doc: https://docs.google.com/document/d/1jpQQX0piaxcHJPWakp_Kr_03g5Gnma5h5-Kdlqu7jVQ/edit#heading=h.k6iklq6rvd30 > > > > Test expectations are changed due to http://crbug.com/705364 > > BUG=588893, 617892, 705364 > > Review-Url: https://codereview.chromium.org/2841443005 > Cr-Commit-Position: refs/heads/master@{#490329} > Committed: https://chromium.googlesource.com/chromium/src/+/54afe29f866e4c3878242de7a78941fc363791e9 TBR=jochen@chromium.org,agrieve@chromium.org,brettw@chromium.org,dcheng@chromium.org,eroman@chromium.org,haraken@chromium.org,jam@chromium.org,mlippautz@chromium.org,rkc@chromium.org,thakis@chromium.org,yukishiino@chromium.org,kinuko@chromium.org,peria@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=588893, 617892, 705364 Review-Url: https://codereview.chromium.org/2989793003 Cr-Commit-Position: refs/heads/master@{#490339} Committed: https://chromium.googlesource.com/chromium/src/+/45b25591b1a63b27f59b95aee8ad0d88aa9833f8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -1680 lines) Patch
M build/config/features.gni View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
M content/app/content_main_runner.cc View 3 chunks +18 lines, -34 lines 0 comments Download
M content/public/app/mojo/content_renderer_manifest.json View 1 chunk +1 line, -7 lines 0 comments Download
M content/public/common/content_descriptor_keys.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_descriptor_keys.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/shell/BUILD.gn View 2 chunks +0 lines, -10 lines 0 comments Download
M extensions/shell/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M gin/isolate_holder.cc View 5 chunks +35 lines, -46 lines 0 comments Download
M gin/public/isolate_holder.h View 2 chunks +2 lines, -6 lines 0 comments Download
M gin/v8_initializer.h View 1 chunk +0 lines, -14 lines 0 comments Download
M gin/v8_initializer.cc View 11 chunks +30 lines, -73 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-320-2x-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-320-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-320-only-viewport-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-980-2x-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-980-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-980-only-viewport-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-controls-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-dw-2x-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-dw-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-initial-scale-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-insets-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-none-2x-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-none-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-restore-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-small-dw-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-small-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/bindings.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp View 8 chunks +28 lines, -52 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/V8ContextSnapshot.h View 1 chunk +0 lines, -79 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/V8ContextSnapshot.cpp View 1 chunk +0 lines, -501 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp View 2 chunks +11 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp View 4 chunks +2 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/BUILD.gn View 2 chunks +0 lines, -35 lines 0 comments Download
D third_party/WebKit/Source/bindings/modules/v8/V8ContextSnapshotExternalReferences.h View 1 chunk +0 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/generated.gni View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/v8.gni View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/bindings/scripts/generate_v8_context_snapshot_external_references.py View 1 chunk +0 lines, -223 lines 0 comments Download
D third_party/WebKit/Source/bindings/templates/external_reference_table.cpp.tmpl View 1 chunk +0 lines, -125 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/templates.gni View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/controller/BlinkInitializer.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/exported/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/exported/WebV8ContextSnapshot.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp View 2 chunks +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/bindings/DOMWrapperWorld.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/bindings/DOMWrapperWorld.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/bindings/ScriptWrappable.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/bindings/V8PerContextData.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/bindings/V8PerIsolateData.h View 6 chunks +5 lines, -41 lines 0 comments Download
M third_party/WebKit/Source/platform/bindings/V8PerIsolateData.cpp View 6 chunks +7 lines, -71 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/Platform.h View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/public/web/WebV8ContextSnapshot.h View 1 chunk +0 lines, -23 lines 0 comments Download
D tools/v8_context_snapshot/BUILD.gn View 1 chunk +0 lines, -97 lines 0 comments Download
D tools/v8_context_snapshot/DEPS View 1 chunk +0 lines, -7 lines 0 comments Download
D tools/v8_context_snapshot/OWNERS View 1 chunk +0 lines, -6 lines 0 comments Download
D tools/v8_context_snapshot/run.py View 1 chunk +0 lines, -15 lines 0 comments Download
D tools/v8_context_snapshot/v8_context_snapshot_generator.cc View 1 chunk +0 lines, -69 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
blundell
Created Revert of [Bindings] Create and use V8 context snapshots
3 years, 4 months ago (2017-07-28 09:47:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2989793003/1
3 years, 4 months ago (2017-07-28 09:47:13 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/45b25591b1a63b27f59b95aee8ad0d88aa9833f8
3 years, 4 months ago (2017-07-28 09:48:46 UTC) #6
haraken
LGTM to revert...
3 years, 4 months ago (2017-07-28 09:52:26 UTC) #7
Yuki
3 years, 4 months ago (2017-07-28 12:03:18 UTC) #8
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698