Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

Issue 2989793003: Revert of [Bindings] Create and use V8 context snapshots (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
index 0847a406c0bfdb659519bdf16a413b2ef6dc653a..29bbbaf414cfbe2ae0fe190010e3d9d94aa57640 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
@@ -35,7 +35,6 @@
#include "bindings/core/v8/SourceLocation.h"
#include "bindings/core/v8/UseCounterCallback.h"
#include "bindings/core/v8/V8BindingForCore.h"
-#include "bindings/core/v8/V8ContextSnapshot.h"
#include "bindings/core/v8/V8DOMException.h"
#include "bindings/core/v8/V8ErrorEvent.h"
#include "bindings/core/v8/V8ErrorHandler.h"
@@ -389,8 +388,6 @@
isolate->SetUseCounterCallback(&UseCounterCallback);
isolate->SetWasmModuleCallback(WasmModuleOverride);
isolate->SetWasmInstanceCallback(WasmInstanceOverride);
-
- V8ContextSnapshot::EnsureInterfaceTemplates(isolate);
}
namespace {
@@ -464,7 +461,7 @@
v8::Isolate::GetCurrent()->AdjustAmountOfExternalAllocatedMemory(diff);
}
-void V8Initializer::InitializeMainThread(intptr_t* reference_table) {
+void V8Initializer::InitializeMainThread() {
DCHECK(IsMainThread());
WTF::ArrayBufferContents::Initialize(AdjustAmountOfExternalAllocatedMemory);
@@ -478,28 +475,13 @@
// NOTE: Some threads (namely utility threads) don't have a scheduler.
WebScheduler* scheduler = Platform::Current()->CurrentThread()->Scheduler();
-
- V8PerIsolateData::V8ContextSnapshotMode v8_context_snapshot_mode =
- Platform::Current()->IsTakingV8ContextSnapshot()
- ? V8PerIsolateData::V8ContextSnapshotMode::kTakeSnapshot
- : V8PerIsolateData::V8ContextSnapshotMode::kUseSnapshot;
- if (v8_context_snapshot_mode ==
- V8PerIsolateData::V8ContextSnapshotMode::kUseSnapshot &&
- !RuntimeEnabledFeatures::V8ContextSnapshotEnabled()) {
- v8_context_snapshot_mode =
- V8PerIsolateData::V8ContextSnapshotMode::kDontUseSnapshot;
- reference_table = nullptr;
- }
- V8ContextSnapshot::SetReferenceTable(reference_table);
-
// When timer task runner is used for PerIsolateData, GC tasks are getting
// throttled and memory usage goes up. For now we're using loading task queue
// to prevent this.
// TODO(altimin): Consider switching to timerTaskRunner here.
v8::Isolate* isolate = V8PerIsolateData::Initialize(
scheduler ? scheduler->LoadingTaskRunner()
- : Platform::Current()->CurrentThread()->GetWebTaskRunner(),
- reference_table, v8_context_snapshot_mode);
+ : Platform::Current()->CurrentThread()->GetWebTaskRunner());
InitializeV8Common(isolate);
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8Initializer.h ('k') | third_party/WebKit/Source/bindings/modules/v8/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698