Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/BUILD.gn

Issue 2989793003: Revert of [Bindings] Create and use V8 context snapshots (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/modules/v8/BUILD.gn
diff --git a/third_party/WebKit/Source/bindings/modules/v8/BUILD.gn b/third_party/WebKit/Source/bindings/modules/v8/BUILD.gn
index fb34ae8dfc4ea8e3b39fde5cecaa9125ff8157c9..28fbedfb346bb11313d743b41aa038d3ab738c25 100644
--- a/third_party/WebKit/Source/bindings/modules/v8/BUILD.gn
+++ b/third_party/WebKit/Source/bindings/modules/v8/BUILD.gn
@@ -16,7 +16,6 @@
":generate_bindings_modules_v8_interfaces",
":generate_bindings_modules_v8_partial_interfaces",
":generate_bindings_modules_v8_partial_interfaces_for_testing",
- ":generate_v8_context_snapshot_external_references",
]
}
@@ -109,37 +108,3 @@
split_count = 5
}
}
-
-action("generate_v8_context_snapshot_external_references") {
- script = "$bindings_scripts_dir/generate_v8_context_snapshot_external_references.py"
- idl_files = core_idl_files + core_idl_with_modules_dependency_files +
- modules_definition_idl_files
- output = bindings_generated_v8_context_snapshot_external_references_file
-
- inputs = idl_files + [ script ]
- outputs = [
- output,
- ]
-
- response_file_contents = rebase_path(idl_files, root_build_dir)
- args = [
- "--cache-dir",
- rebase_path(bindings_scripts_output_dir, root_build_dir),
- "--output",
- rebase_path(output, root_build_dir),
- "--idl-files-list",
- "{{response_file_name}}",
- "--info-dir",
- rebase_path("$bindings_output_dir", root_build_dir),
- "--target-component",
- "modules",
- ]
-
- deps = [
- "//third_party/WebKit/Source/bindings/core:interfaces_info_individual_core",
- "//third_party/WebKit/Source/bindings/modules:interfaces_info",
- "//third_party/WebKit/Source/bindings/modules:interfaces_info_individual_modules",
- "//third_party/WebKit/Source/bindings/scripts:cached_jinja_templates",
- "//third_party/WebKit/Source/bindings/scripts:cached_lex_yacc_tables",
- ]
-}

Powered by Google App Engine
This is Rietveld 408576698