Revert of [Bindings] Create and use V8 context snapshots

third_party/WebKit/Source/platform/bindings/V8PerIsolateData.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 42 matching lines @@
 
 typedef WTF::Vector<DOMDataStore*> DOMDataStoreList;
 
 // Used to hold data that is associated with a single v8::Isolate object, and
 // has a 1:1 relationship with v8::Isolate.
 class PLATFORM_EXPORT V8PerIsolateData {
   USING_FAST_MALLOC(V8PerIsolateData);
   WTF_MAKE_NONCOPYABLE(V8PerIsolateData);
 
  public:
-  enum class V8ContextSnapshotMode {
-    kTakeSnapshot,
-    kDontUseSnapshot,
-    kUseSnapshot,
-  };
-
   class EndOfScopeTask {
     USING_FAST_MALLOC(EndOfScopeTask);
 
    public:
     virtual ~EndOfScopeTask() {}
     virtual void Run() = 0;
   };
 
   // Disables the UseCounter.
   // UseCounter depends on the current context, but it's not available during
@@ skipping 21 matching lines @@
   };
 
   // Use this class to abstract away types of members that are pointers to core/
   // objects, which are simply owned and released by V8PerIsolateData (see
   // m_threadDebugger for an example).
   class PLATFORM_EXPORT Data {
    public:
     virtual ~Data() = default;
   };
 
-  static v8::Isolate* Initialize(WebTaskRunner*,
-                                 intptr_t* refernce_table,
-                                 V8ContextSnapshotMode);
+  static v8::Isolate* Initialize(WebTaskRunner*);
 
   static V8PerIsolateData* From(v8::Isolate* isolate) {
     DCHECK(isolate);
     DCHECK(isolate->GetData(gin::kEmbedderBlink));
     return static_cast<V8PerIsolateData*>(
         isolate->GetData(gin::kEmbedderBlink));
   }
 
   static void WillBeDestroyed(v8::Isolate*);
   static void Destroy(v8::Isolate*);
@@ skipping 22 matching lines @@
 
   V8PrivateProperty* PrivateProperty() { return private_property_.get(); }
 
   // Accessors to the cache of interface templates.
   v8::Local<v8::FunctionTemplate> FindInterfaceTemplate(const DOMWrapperWorld&,
                                                         const void* key);
   void SetInterfaceTemplate(const DOMWrapperWorld&,
                             const void* key,
                             v8::Local<v8::FunctionTemplate>);
 
-  // When v8::SnapshotCreator::CreateBlob() is called, we must not have
-  // persistent handles in Blink. This method clears them.
-  void ClearPersistentsForV8ContextSnapshot();
-
-  v8::SnapshotCreator* GetSnapshotCreator() const {
-    return isolate_holder_.snapshot_creator();
-  }
-  V8ContextSnapshotMode GetV8ContextSnapshotMode() const {
-    return v8_context_snapshot_mode_;
-  }
-
   // Accessor to the cache of cross-origin accessible operation's templates.
   // Created templates get automatically cached.
   v8::Local<v8::FunctionTemplate> FindOrCreateOperationTemplate(
       const DOMWrapperWorld&,
       const void* key,
       v8::FunctionCallback,
       v8::Local<v8::Value> data,
       v8::Local<v8::Signature>,
       int length);
 
@@ skipping 60 matching lines @@
 
   void SetScriptWrappableVisitor(
       std::unique_ptr<ScriptWrappableVisitor> visitor) {
     script_wrappable_visitor_ = std::move(visitor);
   }
   ScriptWrappableVisitor* GetScriptWrappableVisitor() {
     return script_wrappable_visitor_.get();
   }
 
  private:
-  V8PerIsolateData(WebTaskRunner*,
-                   intptr_t* reference_table,
-                   V8ContextSnapshotMode);
-  explicit V8PerIsolateData(intptr_t* reference_table);
+  explicit V8PerIsolateData(WebTaskRunner*);
   ~V8PerIsolateData();
 
-  using V8FunctionTemplateMap =
-      HashMap<const void*, v8::Eternal<v8::FunctionTemplate>>;
+  typedef HashMap<const void*, v8::Eternal<v8::FunctionTemplate>>
+      V8FunctionTemplateMap;
   V8FunctionTemplateMap& SelectInterfaceTemplateMap(const DOMWrapperWorld&);
   V8FunctionTemplateMap& SelectOperationTemplateMap(const DOMWrapperWorld&);
   bool HasInstance(const WrapperTypeInfo* untrusted,
                    v8::Local<v8::Value>,
                    V8FunctionTemplateMap&);
   v8::Local<v8::Object> FindInstanceInPrototypeChain(const WrapperTypeInfo*,
                                                      v8::Local<v8::Value>,
                                                      V8FunctionTemplateMap&);
 
-  V8ContextSnapshotMode v8_context_snapshot_mode_;
-  // This isolate_holder_ must be initialized before initializing some other
-  // members below.
   gin::IsolateHolder isolate_holder_;
 
-  // interface_template_map_for_{,non_}main_world holds function templates for
+  // m_interfaceTemplateMapFor{,Non}MainWorld holds function templates for
   // the inerface objects.
   V8FunctionTemplateMap interface_template_map_for_main_world_;
   V8FunctionTemplateMap interface_template_map_for_non_main_world_;
-
   // m_operationTemplateMapFor{,Non}MainWorld holds function templates for
   // the cross-origin accessible DOM operations.
   V8FunctionTemplateMap operation_template_map_for_main_world_;
   V8FunctionTemplateMap operation_template_map_for_non_main_world_;
 
   // Contains lists of eternal names, such as dictionary keys.
   HashMap<const void*, Vector<v8::Eternal<v8::Name>>> eternal_name_cache_;
 
-  // Members required for the V8 context snapshot.
-  // v8::Context is created from this blob data image. This needs to be
-  // instantiated before |isolate_holder_| gets instantiated.
-  v8::StartupData startup_data_;
-  // When taking a V8 context snapshot, we can't keep V8 objects with eternal
-  // handles. So we use a special interface map that doesn't use eternal handles
-  // instead of the default V8FunctionTemplateMap.
-  V8GlobalValueMap<const WrapperTypeInfo*, v8::FunctionTemplate, v8::kNotWeak>
-      interface_template_map_for_v8_context_snapshot_;
-
   std::unique_ptr<StringCache> string_cache_;
   std::unique_ptr<V8PrivateProperty> private_property_;
   RefPtr<ScriptState> script_regexp_script_state_;
 
   bool constructor_mode_;
   friend class ConstructorMode;
 
   bool use_counter_disabled_;
   friend class UseCounterDisabledScope;
 
   bool is_handling_recursion_level_error_;
   bool is_reporting_exception_;
 
   Vector<std::unique_ptr<EndOfScopeTask>> end_of_scope_tasks_;
   std::unique_ptr<Data> thread_debugger_;
 
   Persistent<ActiveScriptWrappableSet> active_script_wrappables_;
   std::unique_ptr<ScriptWrappableVisitor> script_wrappable_visitor_;
 
   RuntimeCallStats runtime_call_stats_;
 };
 
 }  // namespace blink
 
 #endif  // V8PerIsolateData_h