[milo] remove linkBase and calculate links directly.

[milo] remove linkBase and calculate links directly.

R=hinoka@chromium.org
BUG=468053
Review-Url: https://codereview.chromium.org/2975023002
Committed: https://github.com/luci/luci-go/commit/bad1bfc914d35b3ab6dfc08a79ca35c3210d6665

[iannucci, 2017-07-12 01:08:35]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-12 01:08:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-12 01:10:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-12 01:10:32]

Dry run: Try jobs failed on following builders:
  Luci-go Linux Trusty 32-on-64 Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/374d28f818be5210)
  Luci-go Mac Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/374d28f89c774f10)
  Luci-go Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/374d28f853b16210)

[iannucci, 2017-07-12 02:22:25]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-12 02:22:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-12 02:31:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-12 02:31:42]

Dry run: This issue passed the CQ dry run.

[Ryan Tseng, 2017-07-12 03:52:55]

hinoka@google.com changed reviewers:
+ hinoka@google.com

[Ryan Tseng, 2017-07-12 03:52:56]

lgtm + comment

Also add bug: 468053

https://codereview.chromium.org/2975023002/diff/20001/milo/buildsource/swarmi...
File milo/buildsource/swarming/build.go (right):

https://codereview.chromium.org/2975023002/diff/20001/milo/buildsource/swarmi...
milo/buildsource/swarming/build.go:744: func swarmingURLBuilderForTask(c
context.Context, task string) (rawpresentation.URLBuilder, error) {
Honestly relative urls are fine, most other places use relative URLs, this used
full URLs previously just because it was convenient.

https://codereview.chromium.org/2975023002/diff/20001/milo/buildsource/swarmi...
milo/buildsource/swarming/build.go:756:
"https://%s-dot-%s-dot-%s/swarming/task/%s", toks[0], toks[1], toks[2], task,
"/swarming/task/" + task 

is sufficient

Probably better too, since we don't really want to see blah-dot-blah in all the
places

[iannucci, 2017-07-12 18:08:36]

PTAL (it's better!)

https://codereview.chromium.org/2975023002/diff/20001/milo/buildsource/swarmi...
File milo/buildsource/swarming/build.go (right):

https://codereview.chromium.org/2975023002/diff/20001/milo/buildsource/swarmi...
milo/buildsource/swarming/build.go:744: func swarmingURLBuilderForTask(c
context.Context, task string) (rawpresentation.URLBuilder, error) {
On 2017/07/12 03:52:56, Ryan Tseng wrote:
> Honestly relative urls are fine, most other places use relative URLs, this
used
> full URLs previously just because it was convenient.

Done.

https://codereview.chromium.org/2975023002/diff/20001/milo/buildsource/swarmi...
milo/buildsource/swarming/build.go:756:
"https://%s-dot-%s-dot-%s/swarming/task/%s", toks[0], toks[1], toks[2], task,
On 2017/07/12 03:52:56, Ryan Tseng wrote:
> "/swarming/task/" + task 
> 
> is sufficient
> 
> Probably better too, since we don't really want to see blah-dot-blah in all
the
> places

Done.

[iannucci, 2017-07-12 18:08:42]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-12 18:08:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Tseng, 2017-07-12 18:13:03]

lgtm

still, add a bug link

[commit-bot: I haz the power, 2017-07-12 18:14:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-12 18:14:38]

Dry run: This issue passed the CQ dry run.

[iannucci, 2017-07-12 18:34:01]

Description was changed from

==========
[milo] remove linkBase and calculate links directly.

Depends on https://codereview.chromium.org/2977773002.

R=hinoka@chromium.org
BUG=
==========

to

==========
[milo] remove linkBase and calculate links directly.

R=hinoka@chromium.org
BUG=
==========

[iannucci, 2017-07-12 18:34:24]

Description was changed from

==========
[milo] remove linkBase and calculate links directly.

R=hinoka@chromium.org
BUG=
==========

to

==========
[milo] remove linkBase and calculate links directly.

R=hinoka@chromium.org
BUG=468053
==========

[iannucci, 2017-07-12 18:34:29]

The CQ bit was checked by iannucci@chromium.org

[commit-bot: I haz the power, 2017-07-12 18:34:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-12 18:40:27]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499884469253660,
"parent_rev": "6553a52aeef59501c0b106ff07113b83ad6d179a", "commit_rev":
"bad1bfc914d35b3ab6dfc08a79ca35c3210d6665"}

[commit-bot: I haz the power, 2017-07-12 18:40:30]

Description was changed from

==========
[milo] remove linkBase and calculate links directly.

R=hinoka@chromium.org
BUG=468053
==========

to

==========
[milo] remove linkBase and calculate links directly.

R=hinoka@chromium.org
BUG=468053

Review-Url: https://codereview.chromium.org/2975023002
Committed:
https://github.com/luci/luci-go/commit/bad1bfc914d35b3ab6dfc08a79ca35c3210d6665
==========

[commit-bot: I haz the power, 2017-07-12 18:40:31]

Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/bad1bfc914d35b3ab6dfc08a79ca35c3210d6665