Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 2977773002: [dummy/info] Mock ModuleHostname and related functions. (Closed)

Created:
3 years, 5 months ago by iannucci
Modified:
3 years, 5 months ago
Reviewers:
dnj, hinoka
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M impl/dummy/dummy.go View 1 chunk +12 lines, -3 lines 0 comments Download
M impl/dummy/dummy_test.go View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
iannucci
3 years, 5 months ago (2017-07-12 01:06:46 UTC) #1
dnj
lgtm
3 years, 5 months ago (2017-07-12 01:10:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2977773002/1
3 years, 5 months ago (2017-07-12 01:18:44 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-07-12 01:22:30 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/ddb41673109e1a1ae3128a93b478f63ab28529b2

Powered by Google App Engine
This is Rietveld 408576698