[milo] remove linkBase and calculate links directly.

milo/buildsource/swarming/build_test.go

 // Copyright 2015 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package swarming
 
 import (
         "encoding/json"
         "flag"
         "fmt"
@@ skipping 48 matching lines @@
                 })
 
                 for _, tc := range getTestCases(".") {
                         bl := BuildLoader{
                                 logDogClientFunc: logDogClientFunc(tc),
                         }
                         svc := debugSwarmingService{tc}
 
                         fmt.Printf("Generating expectations for %s\n", tc)
 
-                        build, err := bl.SwarmingBuildImpl(c, svc, "foo", tc.name)
+                        build, err := bl.SwarmingBuildImpl(c, svc, tc.name)
                         if err != nil {
                                 panic(fmt.Errorf("Could not run swarmingBuildImpl for %s: %s", tc, err))
                         }
                         buildJSON, err := json.MarshalIndent(build, "", "  ")
                         if err != nil {
                                 panic(fmt.Errorf("Could not JSON marshal %s: %s", tc.name, err))
                         }
                         filename := filepath.Join("expectations", tc.name+".json")
                         err = ioutil.WriteFile(filename, []byte(buildJSON), 0644)
                         if err != nil {
@@ skipping 21 matching lines @@
                                 }
                                 svc := debugSwarmingService{tc}
 
                                 // Special case: The build-internal test case to check that ACLs should fail.
                                 if tc.name == "build-internal" {
                                         Convey("Should fail", func() {
                                                 c := auth.WithState(c, &authtest.FakeState{
                                                         Identity:       identity.AnonymousIdentity,
                                                         IdentityGroups: []string{"all"},
                                                 })
-                                                _, err := bl.SwarmingBuildImpl(c, svc, "foo", tc.name)
+                                                _, err := bl.SwarmingBuildImpl(c, svc, tc.name)
                                                 So(err.Error(), ShouldResemble, "Not a Milo Job or access denied")
                                         })
                                 }
 
-                                build, err := bl.SwarmingBuildImpl(c, svc, "foo", tc.name)
+                                build, err := bl.SwarmingBuildImpl(c, svc, tc.name)
                                 So(err, ShouldBeNil)
                                 So(build, shouldMatchExpectationsFor, tc.name+".json")
                         })
                 }
         })
 }