Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: milo/buildsource/swarming/build_test.go

Issue 2975023002: [milo] remove linkBase and calculate links directly. (Closed)
Patch Set: common url base Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/buildsource/swarming/build.go ('k') | milo/buildsource/swarming/expectations/build-canceled.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/buildsource/swarming/build_test.go
diff --git a/milo/buildsource/swarming/build_test.go b/milo/buildsource/swarming/build_test.go
index 517cd8fd5c90a3f448c98e728302201cea5b2e4c..47d663b9bc20c2a7ed4218308e1c16e8df8b9d9f 100644
--- a/milo/buildsource/swarming/build_test.go
+++ b/milo/buildsource/swarming/build_test.go
@@ -66,7 +66,7 @@ func TestBuild(t *testing.T) {
fmt.Printf("Generating expectations for %s\n", tc)
- build, err := bl.SwarmingBuildImpl(c, svc, "foo", tc.name)
+ build, err := bl.SwarmingBuildImpl(c, svc, tc.name)
if err != nil {
panic(fmt.Errorf("Could not run swarmingBuildImpl for %s: %s", tc, err))
}
@@ -108,12 +108,12 @@ func TestBuild(t *testing.T) {
Identity: identity.AnonymousIdentity,
IdentityGroups: []string{"all"},
})
- _, err := bl.SwarmingBuildImpl(c, svc, "foo", tc.name)
+ _, err := bl.SwarmingBuildImpl(c, svc, tc.name)
So(err.Error(), ShouldResemble, "Not a Milo Job or access denied")
})
}
- build, err := bl.SwarmingBuildImpl(c, svc, "foo", tc.name)
+ build, err := bl.SwarmingBuildImpl(c, svc, tc.name)
So(err, ShouldBeNil)
So(build, shouldMatchExpectationsFor, tc.name+".json")
})
« no previous file with comments | « milo/buildsource/swarming/build.go ('k') | milo/buildsource/swarming/expectations/build-canceled.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698