Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: milo/buildsource/buildbucket/pubsub.go

Issue 2975023002: [milo] remove linkBase and calculate links directly. (Closed)
Patch Set: common url base Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | milo/buildsource/swarming/build.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/buildsource/buildbucket/pubsub.go
diff --git a/milo/buildsource/buildbucket/pubsub.go b/milo/buildsource/buildbucket/pubsub.go
index a80bbfea35f68f57350fb3c55fae1f11bbadecf7..1aea2c4af97c89fb0958be0293c1ff8c85c2dc81 100644
--- a/milo/buildsource/buildbucket/pubsub.go
+++ b/milo/buildsource/buildbucket/pubsub.go
@@ -99,8 +99,7 @@ func maybeGetBuild(
return nil, err
}
bl := swarming.BuildLoader{}
- // The linkBase is not necessary for the summary.
- return bl.SwarmingBuildImpl(c, swarmingSvc, "", task)
+ return bl.SwarmingBuildImpl(c, swarmingSvc, task)
}
// processBuild queries swarming and logdog for annotation data, then adds or
« no previous file with comments | « no previous file | milo/buildsource/swarming/build.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698