Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 2973503002: Remove unused parameters from MediaStreamVideoSource::StartCaptureImpl() (Closed)

Created:
3 years, 5 months ago by Guido Urdaneta
Modified:
3 years, 5 months ago
Reviewers:
bbudge, hbos_chromium
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, imcheng+watch_chromium.org, feature-media-reviews_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, avayvod+watch_chromium.org, darin-cc_chromium.org, jasonroberts+watch_google.com, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused parameters from MediaStreamVideoSource::StartCaptureImpl() This is part of the removal of the old MediaStream video constraints algorithm. BUG=706408 Review-Url: https://codereview.chromium.org/2973503002 Cr-Commit-Position: refs/heads/master@{#484329} Committed: https://chromium.googlesource.com/chromium/src/+/3c79d018fb4953a250235e6bcbafe7a18d52dc52

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Messages

Total messages: 20 (14 generated)
Guido Urdaneta
hbos@: please review content/renderer/media bbudge@: please review content/renderer/pepper
3 years, 5 months ago (2017-07-04 11:27:13 UTC) #7
hbos_chromium
lgtm https://codereview.chromium.org/2973503002/diff/1/content/renderer/media/media_stream_video_source.h File content/renderer/media/media_stream_video_source.h (right): https://codereview.chromium.org/2973503002/diff/1/content/renderer/media/media_stream_video_source.h#newcode98 content/renderer/media/media_stream_video_source.h:98: const; Optional: Make the public GetCurrentFormat virtual and ...
3 years, 5 months ago (2017-07-04 14:13:51 UTC) #8
Guido Urdaneta
https://codereview.chromium.org/2973503002/diff/1/content/renderer/media/media_stream_video_source.h File content/renderer/media/media_stream_video_source.h (right): https://codereview.chromium.org/2973503002/diff/1/content/renderer/media/media_stream_video_source.h#newcode98 content/renderer/media/media_stream_video_source.h:98: const; On 2017/07/04 14:13:51, hbos_chromium wrote: > Optional: Make ...
3 years, 5 months ago (2017-07-04 14:29:26 UTC) #9
bbudge
lgtm
3 years, 5 months ago (2017-07-05 16:57:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2973503002/20001
3 years, 5 months ago (2017-07-05 19:26:42 UTC) #17
commit-bot: I haz the power
3 years, 5 months ago (2017-07-05 19:31:14 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3c79d018fb4953a250235e6bcbaf...

Powered by Google App Engine
This is Rietveld 408576698