Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 2964923002: Remove unused VideoCapturerSource::GetCurrentSupportedFormats(). (Closed)

Created:
3 years, 5 months ago by Guido Urdaneta
Modified:
3 years, 5 months ago
Reviewers:
mcasas
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, feature-media-reviews_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, mcasas+capturefromelement_chromium.org, darin-cc_chromium.org, xjz+watch_chromium.org, emircan+watch+capturefromdom_chromium.org, miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused VideoCapturerSource::GetCurrentSupportedFormats(). This is part of the removal of the old MediaStream vide constraints algorithm. BUG=706408 Review-Url: https://codereview.chromium.org/2964923002 Cr-Commit-Position: refs/heads/master@{#484342} Committed: https://chromium.googlesource.com/chromium/src/+/4b4b1d4c459daa0834ede9690fafa5da1f37b812

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -54 lines) Patch
M content/renderer/media_capture_from_element/canvas_capture_handler_unittest.cc View 2 chunks +1 line, -16 lines 0 comments Download
M content/renderer/media_capture_from_element/html_video_element_capturer_source_unittest.cc View 2 chunks +2 lines, -18 lines 0 comments Download
M media/capture/video_capturer_source.h View 1 chunk +0 lines, -12 lines 0 comments Download
M media/capture/video_capturer_source.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 29 (20 generated)
Guido Urdaneta
Hi, PTAL
3 years, 5 months ago (2017-07-04 11:29:30 UTC) #5
mcasas
changes LGTM can we use Gerrit please? ( git cl upload -t "..." --gerrit )
3 years, 5 months ago (2017-07-05 00:44:35 UTC) #8
commit-bot: I haz the power
This CL has an open dependency (Issue 2973503002 Patch 1). Please resolve the dependency and ...
3 years, 5 months ago (2017-07-05 07:50:52 UTC) #11
Guido Urdaneta
On 2017/07/05 00:44:35, mcasas wrote: > changes LGTM > > can we use Gerrit please? ...
3 years, 5 months ago (2017-07-05 08:30:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2964923002/20001
3 years, 5 months ago (2017-07-05 15:10:58 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/402384) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 5 months ago (2017-07-05 15:19:39 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2964923002/40001
3 years, 5 months ago (2017-07-05 20:28:41 UTC) #25
commit-bot: I haz the power
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/4b4b1d4c459daa0834ede9690fafa5da1f37b812
3 years, 5 months ago (2017-07-05 20:36:17 UTC) #28
mcasas
3 years, 5 months ago (2017-07-06 06:25:38 UTC) #29
Message was sent while issue was closed.
On 2017/07/05 20:36:17, commit-bot: I haz the power wrote:
> Committed patchset #2 (id:40001) as
>
https://chromium.googlesource.com/chromium/src/+/4b4b1d4c459daa0834ede9690faf...

Re. gerrit vs. rietveld:
https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=f...
?

Powered by Google App Engine
This is Rietveld 408576698