Remove MediaStreamVideoSource::GetCurrentSupportedFormats()

Remove MediaStreamVideoSource::GetCurrentSupportedFormats()

This is part of the removal of old MediaStream video constraints code.

BUG=706408
Review-Url: https://codereview.chromium.org/2972553002
Cr-Commit-Position: refs/heads/master@{#484324}
Committed: https://chromium.googlesource.com/chromium/src/+/9bd16d04a28349748da422fa7361c1832c3cd04e

[Guido Urdaneta, 2017-07-03 19:19:07]

The CQ bit was checked by guidou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-03 19:19:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Guido Urdaneta, 2017-07-03 20:23:41]

guidou@chromium.org changed reviewers:
+ bbudge@chromium.org, mcasas@chromium.org

[Guido Urdaneta, 2017-07-03 20:23:42]

hbos@chromium.prg: Please review changes in content/renderer/media

bbudge@chromium.org: Please review changes in content/renderer/pepper

mcasas@chromium.org: Please review changes in content/renderer/media_recorder

[commit-bot: I haz the power, 2017-07-03 20:31:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-03 20:31:39]

Dry run: This issue passed the CQ dry run.

[mcasas, 2017-07-04 02:01:00]

On 2017/07/03 20:23:42, Guido Urdaneta wrote:
> mailto:hbos@chromium.prg: Please review changes in content/renderer/media
> 
> mailto:bbudge@chromium.org: Please review changes in content/renderer/pepper
> 
> mailto:mcasas@chromium.org: Please review changes in
content/renderer/media_recorder

media_recorder/video_track_recorder_unittest.cc LGTM

[mcasas, 2017-07-04 02:01:15]

On 2017/07/04 02:01:00, mcasas wrote:
> On 2017/07/03 20:23:42, Guido Urdaneta wrote:
> > mailto:hbos@chromium.prg: Please review changes in content/renderer/media
> > 
> > mailto:bbudge@chromium.org: Please review changes in content/renderer/pepper
> > 
> > mailto:mcasas@chromium.org: Please review changes in
> content/renderer/media_recorder
> 
> media_recorder/video_track_recorder_unittest.cc LGTM

( Also, change to gerrit? )

[Guido Urdaneta, 2017-07-04 08:24:02]

Description was changed from

==========
Remove MediaStreamVideoSource::GetCurrentSupportedFormats()

This is part of the removal of old MediaStream video constraints code.

BUG=706408
==========

to

==========
Remove MediaStreamVideoSource::GetCurrentSupportedFormats()

This is part of the removal of old MediaStream video constraints code.

BUG=706408
==========

[Guido Urdaneta, 2017-07-04 08:24:02]

guidou@chromium.org changed reviewers:
+ hbos@chromium.org

[Guido Urdaneta, 2017-07-04 08:24:24]

+hbos@: please review content/renderer/media

[hbos_chromium, 2017-07-04 14:06:34]

lgtm % comment

https://codereview.chromium.org/2972553002/diff/1/content/renderer/media/medi...
File content/renderer/media/media_stream_video_source.h (left):

https://codereview.chromium.org/2972553002/diff/1/content/renderer/media/medi...
content/renderer/media/media_stream_video_source.h:46: // OnStartDone when the
underlying source has been started or failed to start.
OnStartDone is still used, was too much of this comment removed or should it be
rewritten?

[Guido Urdaneta, 2017-07-04 14:30:28]

https://codereview.chromium.org/2972553002/diff/1/content/renderer/media/medi...
File content/renderer/media/media_stream_video_source.h (left):

https://codereview.chromium.org/2972553002/diff/1/content/renderer/media/medi...
content/renderer/media/media_stream_video_source.h:46: // OnStartDone when the
underlying source has been started or failed to start.
I intentionally removed the part about OnStartDone since it's to detailed for a
class comment.

The StartSourceImpl() comment mentions the bit about OnStartDone.

[bbudge, 2017-07-05 16:57:45]

lgtm

[Guido Urdaneta, 2017-07-05 17:09:56]

The CQ bit was checked by guidou@chromium.org

[Guido Urdaneta, 2017-07-05 17:09:57]

The patchset sent to the CQ was uploaded after l-g-t-m from mcasas@chromium.org,
hbos@chromium.org
Link to the patchset: https://codereview.chromium.org/2972553002/#ps20001
(title: "remove extra use in media_stream_video_capturer_source_unittest.cc")

[commit-bot: I haz the power, 2017-07-05 17:10:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-05 19:06:53]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499274596576960,
"parent_rev": "aa18e6121b447515f311797433f0b49e1913459c", "commit_rev":
"9bd16d04a28349748da422fa7361c1832c3cd04e"}

[commit-bot: I haz the power, 2017-07-05 19:07:07]

Description was changed from

==========
Remove MediaStreamVideoSource::GetCurrentSupportedFormats()

This is part of the removal of old MediaStream video constraints code.

BUG=706408
==========

to

==========
Remove MediaStreamVideoSource::GetCurrentSupportedFormats()

This is part of the removal of old MediaStream video constraints code.

BUG=706408

Review-Url: https://codereview.chromium.org/2972553002
Cr-Commit-Position: refs/heads/master@{#484324}
Committed:
https://chromium.googlesource.com/chromium/src/+/9bd16d04a28349748da422fa7361...
==========

[commit-bot: I haz the power, 2017-07-05 19:07:09]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9bd16d04a28349748da422fa7361...