Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Side by Side Diff: content/renderer/media/webrtc/media_stream_remote_video_source.h

Issue 2973503002: Remove unused parameters from MediaStreamVideoSource::StartCaptureImpl() (Closed)
Patch Set: rebase Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_MEDIA_WEBRTC_MEDIA_STREAM_REMOTE_VIDEO_SOURCE_H_ 5 #ifndef CONTENT_RENDERER_MEDIA_WEBRTC_MEDIA_STREAM_REMOTE_VIDEO_SOURCE_H_
6 #define CONTENT_RENDERER_MEDIA_WEBRTC_MEDIA_STREAM_REMOTE_VIDEO_SOURCE_H_ 6 #define CONTENT_RENDERER_MEDIA_WEBRTC_MEDIA_STREAM_REMOTE_VIDEO_SOURCE_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 20 matching lines...) Expand all
31 ~MediaStreamRemoteVideoSource() override; 31 ~MediaStreamRemoteVideoSource() override;
32 32
33 // Should be called when the remote video track this source originates from is 33 // Should be called when the remote video track this source originates from is
34 // no longer received on a PeerConnection. This cleans up the references to 34 // no longer received on a PeerConnection. This cleans up the references to
35 // the webrtc::MediaStreamTrackInterface instance held by |observer_|. 35 // the webrtc::MediaStreamTrackInterface instance held by |observer_|.
36 void OnSourceTerminated(); 36 void OnSourceTerminated();
37 37
38 protected: 38 protected:
39 // Implements MediaStreamVideoSource. 39 // Implements MediaStreamVideoSource.
40 void StartSourceImpl( 40 void StartSourceImpl(
41 const media::VideoCaptureFormat& format,
42 const blink::WebMediaConstraints& constraints,
43 const VideoCaptureDeliverFrameCB& frame_callback) override; 41 const VideoCaptureDeliverFrameCB& frame_callback) override;
44 42
45 void StopSourceImpl() override; 43 void StopSourceImpl() override;
46 44
47 // Used by tests to test that a frame can be received and that the 45 // Used by tests to test that a frame can be received and that the
48 // MediaStreamRemoteVideoSource behaves as expected. 46 // MediaStreamRemoteVideoSource behaves as expected.
49 rtc::VideoSinkInterface<webrtc::VideoFrame>* SinkInterfaceForTest(); 47 rtc::VideoSinkInterface<webrtc::VideoFrame>* SinkInterfaceForTest();
50 48
51 private: 49 private:
52 void OnChanged(webrtc::MediaStreamTrackInterface::TrackState state); 50 void OnChanged(webrtc::MediaStreamTrackInterface::TrackState state);
53 51
54 // Internal class used for receiving frames from the webrtc track on a 52 // Internal class used for receiving frames from the webrtc track on a
55 // libjingle thread and forward it to the IO-thread. 53 // libjingle thread and forward it to the IO-thread.
56 class RemoteVideoSourceDelegate; 54 class RemoteVideoSourceDelegate;
57 scoped_refptr<RemoteVideoSourceDelegate> delegate_; 55 scoped_refptr<RemoteVideoSourceDelegate> delegate_;
58 std::unique_ptr<TrackObserver> observer_; 56 std::unique_ptr<TrackObserver> observer_;
59 57
60 DISALLOW_COPY_AND_ASSIGN(MediaStreamRemoteVideoSource); 58 DISALLOW_COPY_AND_ASSIGN(MediaStreamRemoteVideoSource);
61 }; 59 };
62 60
63 } // namespace content 61 } // namespace content
64 62
65 #endif // CONTENT_RENDERER_MEDIA_WEBRTC_MEDIA_STREAM_REMOTE_VIDEO_SOURCE_H_ 63 #endif // CONTENT_RENDERER_MEDIA_WEBRTC_MEDIA_STREAM_REMOTE_VIDEO_SOURCE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698