Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: content/renderer/media/media_stream_video_source.h

Issue 2973503002: Remove unused parameters from MediaStreamVideoSource::StartCaptureImpl() (Closed)
Patch Set: rebase Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/media_stream_video_source.h
diff --git a/content/renderer/media/media_stream_video_source.h b/content/renderer/media/media_stream_video_source.h
index 4e3139c05f952e3c365ae55f1e0dcf32488ab8a2..235f5fab3eccf08aeabd7037d8953ea578120f19 100644
--- a/content/renderer/media/media_stream_video_source.h
+++ b/content/renderer/media/media_stream_video_source.h
@@ -93,21 +93,15 @@ class CONTENT_EXPORT MediaStreamVideoSource : public MediaStreamSource {
// Sets muted state and notifies it to all registered tracks.
virtual void SetMutedState(bool state);
- // TODO(guidou): Rename to GetCurrentFormat. http://crbug.com/706804
+ // An implementation must return its capture format if available.
virtual base::Optional<media::VideoCaptureFormat> GetCurrentFormatImpl()
const;
- // An implementation must start capturing frames using the requested
- // |format|. The fulfilled |constraints| are provided as additional context,
- // and may be used to modify the behavior of the source. When the source has
- // started or the source failed to start OnStartDone must be called. An
- // implementation must call |frame_callback| on the IO thread with the
+ // An implementation must start capturing frames after this method is called.
+ // When the source has started or failed to start OnStartDone must be called.
+ // An implementation must call |frame_callback| on the IO thread with the
// captured frames.
- // TODO(guidou): Remove |format| and |constraints| parameters.
- // http://crbug.com/706408
virtual void StartSourceImpl(
- const media::VideoCaptureFormat& format,
- const blink::WebMediaConstraints& constraints,
const VideoCaptureDeliverFrameCB& frame_callback) = 0;
void OnStartDone(MediaStreamRequestResult result);
« no previous file with comments | « content/renderer/media/media_stream_video_capturer_source.cc ('k') | content/renderer/media/media_stream_video_source.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698