Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2953243002: FocusManagerFactory::Create() should return a unique_ptr. (Closed)

Created:
3 years, 6 months ago by Lei Zhang
Modified:
3 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

FocusManagerFactory::Create() should return a unique_ptr. Clean up nits in surrounding code. Review-Url: https://codereview.chromium.org/2953243002 Cr-Commit-Position: refs/heads/master@{#481987} Committed: https://chromium.googlesource.com/chromium/src/+/20bc73b78285f84b6e53c3b14817e57b8ad67e7e

Patch Set 1 #

Patch Set 2 : build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -29 lines) Patch
M ash/accelerators/ash_focus_manager_factory.h View 1 1 chunk +6 lines, -2 lines 0 comments Download
M ash/accelerators/ash_focus_manager_factory.cc View 1 1 chunk +7 lines, -7 lines 0 comments Download
M ui/views/focus/focus_manager_factory.h View 3 chunks +8 lines, -4 lines 0 comments Download
M ui/views/focus/focus_manager_factory.cc View 3 chunks +14 lines, -12 lines 0 comments Download
M ui/views/focus/focus_manager_unittest.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M ui/views/widget/widget.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (13 generated)
Lei Zhang
3 years, 6 months ago (2017-06-23 18:25:41 UTC) #11
sky
LGTM
3 years, 6 months ago (2017-06-23 19:18:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2953243002/20001
3 years, 6 months ago (2017-06-23 19:20:17 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 19:25:39 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/20bc73b78285f84b6e53c3b14817...

Powered by Google App Engine
This is Rietveld 408576698