Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Side by Side Diff: ui/views/focus/focus_manager_factory.cc

Issue 2953243002: FocusManagerFactory::Create() should return a unique_ptr. (Closed)
Patch Set: build Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/views/focus/focus_manager_factory.h ('k') | ui/views/focus/focus_manager_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/views/focus/focus_manager_factory.h" 5 #include "ui/views/focus/focus_manager_factory.h"
6 6
7 #include "base/memory/ptr_util.h"
7 #include "ui/views/focus/focus_manager.h" 8 #include "ui/views/focus/focus_manager.h"
8 #include "ui/views/focus/focus_manager_delegate.h" 9 #include "ui/views/focus/focus_manager_delegate.h"
9 10
10 namespace views { 11 namespace views {
11 12
12 namespace { 13 namespace {
13 14
14 class DefaultFocusManagerFactory : public FocusManagerFactory { 15 class DefaultFocusManagerFactory : public FocusManagerFactory {
15 public: 16 public:
16 DefaultFocusManagerFactory() : FocusManagerFactory() {} 17 DefaultFocusManagerFactory() : FocusManagerFactory() {}
17 ~DefaultFocusManagerFactory() override {} 18 ~DefaultFocusManagerFactory() override {}
18 19
19 protected: 20 protected:
20 FocusManager* CreateFocusManager(Widget* widget, 21 std::unique_ptr<FocusManager> CreateFocusManager(
21 bool desktop_widget) override { 22 Widget* widget,
22 return new FocusManager(widget, nullptr /* delegate */); 23 bool desktop_widget) override {
24 return base::MakeUnique<FocusManager>(widget, nullptr /* delegate */);
23 } 25 }
24 26
25 private: 27 private:
26 DISALLOW_COPY_AND_ASSIGN(DefaultFocusManagerFactory); 28 DISALLOW_COPY_AND_ASSIGN(DefaultFocusManagerFactory);
27 }; 29 };
28 30
29 FocusManagerFactory* focus_manager_factory = nullptr; 31 FocusManagerFactory* g_focus_manager_factory = nullptr;
30 32
31 } // namespace 33 } // namespace
32 34
33 FocusManagerFactory::FocusManagerFactory() { 35 FocusManagerFactory::FocusManagerFactory() {
34 } 36 }
35 37
36 FocusManagerFactory::~FocusManagerFactory() { 38 FocusManagerFactory::~FocusManagerFactory() {
37 } 39 }
38 40
39 // static 41 // static
40 FocusManager* FocusManagerFactory::Create(Widget* widget, 42 std::unique_ptr<FocusManager> FocusManagerFactory::Create(Widget* widget,
41 bool desktop_widget) { 43 bool desktop_widget) {
42 if (!focus_manager_factory) 44 if (!g_focus_manager_factory)
43 focus_manager_factory = new DefaultFocusManagerFactory(); 45 g_focus_manager_factory = new DefaultFocusManagerFactory();
44 return focus_manager_factory->CreateFocusManager(widget, desktop_widget); 46 return g_focus_manager_factory->CreateFocusManager(widget, desktop_widget);
45 } 47 }
46 48
47 // static 49 // static
48 void FocusManagerFactory::Install(FocusManagerFactory* f) { 50 void FocusManagerFactory::Install(FocusManagerFactory* f) {
49 if (f == focus_manager_factory) 51 if (f == g_focus_manager_factory)
50 return; 52 return;
51 delete focus_manager_factory; 53 delete g_focus_manager_factory;
52 focus_manager_factory = f ? f : new DefaultFocusManagerFactory(); 54 g_focus_manager_factory = f ? f : new DefaultFocusManagerFactory();
53 } 55 }
54 56
55 } // namespace views 57 } // namespace views
OLDNEW
« no previous file with comments | « ui/views/focus/focus_manager_factory.h ('k') | ui/views/focus/focus_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698