ui/views/widget/widget.cc - Issue 2953243002: FocusManagerFactory::Create() should return a unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/widget.cc

Issue 2953243002: FocusManagerFactory::Create() should return a unique_ptr. (Closed)

Patch Set: build Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/widget/widget.cc

diff --git a/ui/views/widget/widget.cc b/ui/views/widget/widget.cc

index a0394435bf7d0343de28ee58df12d72aa361e43a..32a50e8860a999193a1f5230de8d55a95377b4cb 100644

--- a/ui/views/widget/widget.cc

+++ b/ui/views/widget/widget.cc

@@ -1069,7 +1069,7 @@ void Widget::OnNativeWidgetVisibilityChanged(bool visible) {

void Widget::OnNativeWidgetCreated(bool desktop_widget) {

if (is_top_level())

- focus_manager_.reset(FocusManagerFactory::Create(this, desktop_widget));

+ focus_manager_ = FocusManagerFactory::Create(this, desktop_widget);

native_widget_->InitModalType(widget_delegate_->GetModalType());

« no previous file with comments | « ui/views/focus/focus_manager_unittest.cc ('k') | no next file » | no next file with comments »