Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: ui/views/focus/focus_manager_unittest.cc

Issue 2953243002: FocusManagerFactory::Create() should return a unique_ptr. (Closed)
Patch Set: build Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/focus/focus_manager_factory.cc ('k') | ui/views/widget/widget.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/focus/focus_manager_unittest.cc
diff --git a/ui/views/focus/focus_manager_unittest.cc b/ui/views/focus/focus_manager_unittest.cc
index bafea1ecf8c2367153232707b4d85c571c61bca6..7137786c3566d055a7a97509fc5ab1f4729912af 100644
--- a/ui/views/focus/focus_manager_unittest.cc
+++ b/ui/views/focus/focus_manager_unittest.cc
@@ -11,6 +11,7 @@
#include "base/command_line.h"
#include "base/macros.h"
+#include "base/memory/ptr_util.h"
#include "base/strings/utf_string_conversions.h"
#include "ui/base/accelerators/accelerator.h"
#include "ui/events/keycodes/keyboard_codes.h"
@@ -477,14 +478,17 @@ class FocusManagerDtorTest : public FocusManagerTest {
explicit TestFocusManagerFactory(DtorTrackVector* dtor_tracker)
: dtor_tracker_(dtor_tracker) {
}
+ ~TestFocusManagerFactory() override {}
- FocusManager* CreateFocusManager(Widget* widget,
- bool desktop_widget) override {
- return new FocusManagerDtorTracked(widget, dtor_tracker_);
+ std::unique_ptr<FocusManager> CreateFocusManager(
+ Widget* widget,
+ bool desktop_widget) override {
+ return base::MakeUnique<FocusManagerDtorTracked>(widget, dtor_tracker_);
}
private:
DtorTrackVector* dtor_tracker_;
+
DISALLOW_COPY_AND_ASSIGN(TestFocusManagerFactory);
};
« no previous file with comments | « ui/views/focus/focus_manager_factory.cc ('k') | ui/views/widget/widget.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698