Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2951403002: Update comments for net/data/verify_certificate_chain_unittest/ (Closed)

Created:
3 years, 6 months ago by eroman
Modified:
3 years, 6 months ago
Reviewers:
mattm
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, cbentzel+watch_chromium.org, extensions-reviews_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update comments for net/data/verify_certificate_chain_unittest/ * Remove some older language about trust anchors, and consistently refer to "root certificate" instead * Omit trivia about the chain (like count of certificates), and focus description on what makes it special * Don't refer to expected validation success/failure in the chain descriptions. Instead this logically belongs in the .test file (I didn't add comments to the .test files... however the error messages should be self-descriptive). Review-Url: https://codereview.chromium.org/2951403002 Cr-Commit-Position: refs/heads/master@{#481816} Committed: https://chromium.googlesource.com/chromium/src/+/9e3eeee7b6604d0862a15de01b706e8507114f77

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -242 lines) Patch
M net/data/verify_certificate_chain_unittest/basic-constraints-pathlen-0-self-issued/chain.pem View 1 chunk +2 lines, -3 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/basic-constraints-pathlen-0-self-issued/generate-chains.py View 1 chunk +3 lines, -4 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/expired-intermediate/chain.pem View 1 chunk +2 lines, -3 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/expired-intermediate/generate-chains.py View 1 chunk +2 lines, -3 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/expired-root/chain.pem View 1 chunk +2 lines, -3 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/expired-root/generate-chains.py View 1 chunk +2 lines, -3 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/expired-target/chain.pem View 1 chunk +2 lines, -3 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/expired-target/generate-chains.py View 1 chunk +2 lines, -3 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/incorrect-trust-anchor/chain.pem View 1 chunk +5 lines, -3 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/incorrect-trust-anchor/generate-chains.py View 2 chunks +8 lines, -6 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/intermediate-basic-constraints-ca-false/chain.pem View 1 chunk +2 lines, -3 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/intermediate-basic-constraints-ca-false/generate-chains.py View 1 chunk +3 lines, -4 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/intermediate-basic-constraints-not-critical/chain.pem View 1 chunk +2 lines, -4 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/intermediate-basic-constraints-not-critical/generate-chains.py View 1 chunk +4 lines, -6 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/intermediate-eku-any-and-clientauth/chain.pem View 1 chunk +2 lines, -4 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/intermediate-eku-any-and-clientauth/generate-chains.py View 1 chunk +3 lines, -5 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/intermediate-eku-clientauth/chain.pem View 1 chunk +2 lines, -3 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/intermediate-eku-clientauth/generate-chains.py View 1 chunk +3 lines, -4 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/intermediate-lacks-basic-constraints/chain.pem View 1 chunk +2 lines, -3 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/intermediate-lacks-basic-constraints/generate-chains.py View 1 chunk +3 lines, -4 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/intermediate-lacks-signing-key-usage/chain.pem View 1 chunk +1 line, -3 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/intermediate-lacks-signing-key-usage/generate-chains.py View 1 chunk +2 lines, -4 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/intermediate-signed-with-md5/chain.pem View 1 chunk +2 lines, -3 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/intermediate-signed-with-md5/generate-chains.py View 1 chunk +3 lines, -4 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/intermediate-unknown-critical-extension/chain.pem View 1 chunk +2 lines, -4 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/intermediate-unknown-critical-extension/generate-chains.py View 1 chunk +3 lines, -5 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/intermediate-unknown-non-critical-extension/chain.pem View 1 chunk +2 lines, -4 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/intermediate-unknown-non-critical-extension/generate-chains.py View 1 chunk +3 lines, -5 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/non-self-signed-root/chain.pem View 1 chunk +2 lines, -3 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/non-self-signed-root/generate-chains.py View 2 chunks +3 lines, -4 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/root-basic-constraints-ca-false/chain.pem View 1 chunk +2 lines, -4 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/root-basic-constraints-ca-false/generate-chains.py View 1 chunk +3 lines, -6 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/root-eku-clientauth/chain.pem View 1 chunk +2 lines, -4 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/root-eku-clientauth/generate-chains.py View 1 chunk +3 lines, -6 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/root-lacks-basic-constraints/chain.pem View 1 chunk +2 lines, -3 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/root-lacks-basic-constraints/generate-chains.py View 1 chunk +3 lines, -4 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-and-intermediate/chain.pem View 1 chunk +2 lines, -2 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-and-intermediate/generate-chains.py View 1 chunk +3 lines, -3 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-eku-clientauth/chain.pem View 1 chunk +2 lines, -3 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-eku-clientauth/generate-chains.py View 1 chunk +3 lines, -4 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-eku-none/chain.pem View 1 chunk +2 lines, -3 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-eku-none/generate-chains.py View 1 chunk +3 lines, -4 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-has-keycertsign-but-not-ca/chain.pem View 1 chunk +3 lines, -4 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-has-keycertsign-but-not-ca/generate-chains.py View 1 chunk +4 lines, -5 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-has-pathlen-but-not-ca/chain.pem View 1 chunk +2 lines, -3 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-has-pathlen-but-not-ca/generate-chains.py View 1 chunk +3 lines, -4 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-not-end-entity/chain.pem View 1 chunk +2 lines, -3 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-not-end-entity/generate-chains.py View 1 chunk +3 lines, -4 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-serverauth-various-keyusages/ec-decipherOnly.pem View 1 chunk +1 line, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/target-serverauth-various-keyusages/ec-digitalSignature.pem View 1 chunk +1 line, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/target-serverauth-various-keyusages/ec-keyAgreement.pem View 1 chunk +1 line, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/target-serverauth-various-keyusages/ec-keyEncipherment.pem View 1 chunk +1 line, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/target-serverauth-various-keyusages/generate-chains.py View 1 chunk +3 lines, -2 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-serverauth-various-keyusages/rsa-decipherOnly.pem View 1 chunk +1 line, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/target-serverauth-various-keyusages/rsa-digitalSignature.pem View 1 chunk +1 line, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/target-serverauth-various-keyusages/rsa-keyAgreement.pem View 1 chunk +1 line, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/target-serverauth-various-keyusages/rsa-keyEncipherment.pem View 1 chunk +1 line, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/target-signed-by-512bit-rsa/chain.pem View 1 chunk +2 lines, -3 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-signed-by-512bit-rsa/generate-chains.py View 1 chunk +3 lines, -4 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-signed-using-ecdsa/chain.pem View 1 chunk +3 lines, -2 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-signed-using-ecdsa/generate-chains.py View 1 chunk +4 lines, -3 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-signed-with-md5/chain.pem View 1 chunk +2 lines, -2 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-signed-with-md5/generate-chains.py View 1 chunk +3 lines, -3 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-unknown-critical-extension/chain.pem View 1 chunk +2 lines, -4 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-unknown-critical-extension/generate-chains.py View 1 chunk +3 lines, -5 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-wrong-signature/chain.pem View 1 chunk +1 line, -3 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-wrong-signature/generate-chains.py View 1 chunk +2 lines, -4 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/unknown-critical-policy-qualifier/chain.pem View 1 chunk +2 lines, -2 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/unknown-critical-policy-qualifier/generate-chains.py View 1 chunk +3 lines, -3 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/unknown-non-critical-policy-qualifier/chain.pem View 1 chunk +2 lines, -2 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/unknown-non-critical-policy-qualifier/generate-chains.py View 1 chunk +3 lines, -3 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/violates-basic-constraints-pathlen-0/chain.pem View 1 chunk +2 lines, -3 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/violates-basic-constraints-pathlen-0/generate-chains.py View 1 chunk +3 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
eroman
(I split this off from the earlier CL I sent out)
3 years, 6 months ago (2017-06-22 22:14:37 UTC) #2
mattm
lgtm
3 years, 6 months ago (2017-06-22 23:18:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2951403002/1
3 years, 6 months ago (2017-06-23 05:23:49 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 06:02:28 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9e3eeee7b6604d0862a15de01b70...

Powered by Google App Engine
This is Rietveld 408576698