net/data/verify_certificate_chain_unittest/intermediate-lacks-signing-key-usage/chain.pem - Issue 2951403002: Update comments for net/data/verify_certificate_chain_unittest/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/data/verify_certificate_chain_unittest/intermediate-lacks-signing-key-usage/chain.pem

Issue 2951403002: Update comments for net/data/verify_certificate_chain_unittest/ (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « net/data/verify_certificate_chain_unittest/intermediate-lacks-basic-constraints/generate-chains.py ('k') | net/data/verify_certificate_chain_unittest/intermediate-lacks-signing-key-usage/generate-chains.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/data/verify_certificate_chain_unittest/intermediate-lacks-signing-key-usage/chain.pem

diff --git a/net/data/verify_certificate_chain_unittest/intermediate-lacks-signing-key-usage/chain.pem b/net/data/verify_certificate_chain_unittest/intermediate-lacks-signing-key-usage/chain.pem

index e646cf63761d97528520d08b0fd558edeb83e808..04d5660b8ab6efe99479fed56cccaf3cacb9455f 100644

--- a/net/data/verify_certificate_chain_unittest/intermediate-lacks-signing-key-usage/chain.pem

+++ b/net/data/verify_certificate_chain_unittest/intermediate-lacks-signing-key-usage/chain.pem

@@ -1,8 +1,6 @@

[Created by: generate-chains.py]

-Certificate chain with 1 intermediate and a trusted root. The intermediate

-contains a keyUsage extension, HOWEVER it does not contain the keyCertSign bit.

-Hence validation is expected to fail.

+Certificate chain where the intermediate lacks a keyUsage extension.

Certificate:

Data: