net/data/verify_certificate_chain_unittest/target-unknown-critical-extension/generate-chains.py - Issue 2951403002: Update comments for net/data/verify_certificate_chain_unittest/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/data/verify_certificate_chain_unittest/target-unknown-critical-extension/generate-chains.py

Issue 2951403002: Update comments for net/data/verify_certificate_chain_unittest/ (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « net/data/verify_certificate_chain_unittest/target-unknown-critical-extension/chain.pem ('k') | net/data/verify_certificate_chain_unittest/target-wrong-signature/chain.pem » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/data/verify_certificate_chain_unittest/target-unknown-critical-extension/generate-chains.py

diff --git a/net/data/verify_certificate_chain_unittest/target-unknown-critical-extension/generate-chains.py b/net/data/verify_certificate_chain_unittest/target-unknown-critical-extension/generate-chains.py

index f1d43a4dbb736f9b41b87fdb727933c911ef1f84..ce94161b6c71070982db8e12740c190c1d85a7a1 100755

--- a/net/data/verify_certificate_chain_unittest/target-unknown-critical-extension/generate-chains.py

+++ b/net/data/verify_certificate_chain_unittest/target-unknown-critical-extension/generate-chains.py

@@ -3,17 +3,15 @@

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

-"""Certificate chain with 1 intermediate and a trusted root. The target

-certificate has an unknown X.509v3 extension (OID=1.2.3.4) that is marked as

-critical. Verifying this certificate chain is expected to fail because there is

-an unrecognized critical extension."""

+"""Certificate chain where the target certificate contains an unknown X.509v3

+extension (OID=1.2.3.4) that is marked as critical."""

import sys

sys.path += ['..']

import common

-# Self-signed root certificate (used as trust anchor).

+# Self-signed root certificate.

root = common.create_self_signed_root_certificate('Root')

# Intermediate certificate.