net/data/verify_certificate_chain_unittest/target-has-keycertsign-but-not-ca/chain.pem - Issue 2951403002: Update comments for net/data/verify_certificate_chain_unittest/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/data/verify_certificate_chain_unittest/target-has-keycertsign-but-not-ca/chain.pem

Issue 2951403002: Update comments for net/data/verify_certificate_chain_unittest/ (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « net/data/verify_certificate_chain_unittest/target-eku-none/generate-chains.py ('k') | net/data/verify_certificate_chain_unittest/target-has-keycertsign-but-not-ca/generate-chains.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/data/verify_certificate_chain_unittest/target-has-keycertsign-but-not-ca/chain.pem

diff --git a/net/data/verify_certificate_chain_unittest/target-has-keycertsign-but-not-ca/chain.pem b/net/data/verify_certificate_chain_unittest/target-has-keycertsign-but-not-ca/chain.pem

index 6ddc5ff7f68cee89372a48520d56ad1bb4c8b363..b168de1787cb0830581ba50d525f8ef3014fa659 100644

--- a/net/data/verify_certificate_chain_unittest/target-has-keycertsign-but-not-ca/chain.pem

+++ b/net/data/verify_certificate_chain_unittest/target-has-keycertsign-but-not-ca/chain.pem

@@ -1,9 +1,8 @@

[Created by: generate-chains.py]

-Certificate chain with 1 intermediate, a trusted root, and a target

-certificate that is not a CA, and yet has the keyCertSign bit set. Verification

-is expected to fail, since keyCertSign should only be asserted when CA is

-true.

+Certificate chain where the leaf certificate asserts the keyCertSign key

+usage, however does not have CA=true in the basic constraints extension to

+indicate it is a CA.

Certificate:

Data: