Add extra path validation tests for EKU processing

Add extra path validation tests for EKU processing

* Combines duplicate certificate chains that were named with "-ok" vs "-fail" (these predated ability to set expectations in .test files)

* Adds .test files for each chain for ANY_EKU, CLIENT_AUTH and SERVER_AUTH

Review-Url: https://codereview.chromium.org/2931053002
Cr-Commit-Position: refs/heads/master@{#481772}
Committed: https://chromium.googlesource.com/chromium/src/+/7333d9b7e9e6d13295c6212acb9acc4447501953

[eroman, 2017-06-09 01:51:17]

eroman@chromium.org changed reviewers:
+ mattm@chromium.org

[eroman, 2017-06-09 01:51:36]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 01:51:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mattm, 2017-06-09 02:20:36]

Could you split this up a bit? Like all the ones that are just comment changes
in a separate CL?

[commit-bot: I haz the power, 2017-06-09 02:24:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 02:24:46]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[eroman, 2017-06-22 21:42:53]

Description was changed from

==========
Update some certificate chain tests.

Mostly just updates comments, but also adds some extra tests for
extended key usage.
==========

to

==========
Add extra path validation tests for EKU processing

* Combines duplicate certificate chains that were named with "-ok" vs "-fail"
(these predated ability to set expectations in .test files)

* Adds .test files for each chain for ANY_EKU, CLIENT_AUTH and SERVER_AUTH
==========

[eroman, 2017-06-22 21:43:03]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 21:43:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2017-06-22 21:44:59]

On Thu, Jun 8, 2017 at 7:20 PM, <mattm@chromium.org> wrote:

> Could you split this up a bit? Like all the ones that are just comment
> changes
> in a separate CL?
>

Done -- I removed all of the comment changes, and updated the CL
description accordingly.


>
> https://codereview.chromium.org/2931053002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[mattm, 2017-06-22 23:18:09]

On 2017/06/22 21:44:59, eroman wrote:
> On Thu, Jun 8, 2017 at 7:20 PM, <mailto:mattm@chromium.org> wrote:
> 
> > Could you split this up a bit? Like all the ones that are just comment
> > changes
> > in a separate CL?
> >
> 
> Done -- I removed all of the comment changes, and updated the CL
> description accordingly.
> 

Thanks! 
lgtm

[commit-bot: I haz the power, 2017-06-23 01:00:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-23 01:00:41]

Dry run: This issue passed the CQ dry run.

[eroman, 2017-06-23 01:45:31]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2017-06-23 01:45:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 01:50:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498182331431060,
"parent_rev": "9c2e819efcdc03780bbb2f45a322af5d681207dc", "commit_rev":
"b2127eacbecfbabc578d86f6716e5e14840e9da2"}

[commit-bot: I haz the power, 2017-06-23 01:50:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498182331431060,
"parent_rev": "247215d39e070e9e9d9ff4dc58a6f37682a5d125", "commit_rev":
"7333d9b7e9e6d13295c6212acb9acc4447501953"}

[commit-bot: I haz the power, 2017-06-23 01:50:56]

Description was changed from

==========
Add extra path validation tests for EKU processing

* Combines duplicate certificate chains that were named with "-ok" vs "-fail"
(these predated ability to set expectations in .test files)

* Adds .test files for each chain for ANY_EKU, CLIENT_AUTH and SERVER_AUTH
==========

to

==========
Add extra path validation tests for EKU processing

* Combines duplicate certificate chains that were named with "-ok" vs "-fail"
(these predated ability to set expectations in .test files)

* Adds .test files for each chain for ANY_EKU, CLIENT_AUTH and SERVER_AUTH

Review-Url: https://codereview.chromium.org/2931053002
Cr-Commit-Position: refs/heads/master@{#481772}
Committed:
https://chromium.googlesource.com/chromium/src/+/7333d9b7e9e6d13295c6212acb9a...
==========

[commit-bot: I haz the power, 2017-06-23 01:50:58]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7333d9b7e9e6d13295c6212acb9a...