[ObjC ARC] Converts ios/chrome/browser/ui/stack_view:stack_view to ARC.

[ObjC ARC] Converts ios/chrome/browser/ui/stack_view:stack_view to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2944443003
Cr-Commit-Position: refs/heads/master@{#481177}
Committed: https://chromium.googlesource.com/chromium/src/+/6a9b847e0cbcfd1c8858a8fd63062221f5f96775

[marq (ping after 24h), 2017-06-15 16:52:14]

The CQ bit was checked by marq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-15 16:52:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marq (ping after 24h), 2017-06-15 16:54:54]

marq@chromium.org changed reviewers:
+ sdefresne@chromium.org, stkhapugin@chromium.org

[commit-bot: I haz the power, 2017-06-15 18:59:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 18:59:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stkhapugin, 2017-06-16 13:17:50]

lgtm with comments

https://codereview.chromium.org/2944443003/diff/1/ios/chrome/browser/ui/stack...
File ios/chrome/browser/ui/stack_view/card_set.h (right):

https://codereview.chromium.org/2944443003/diff/1/ios/chrome/browser/ui/stack...
ios/chrome/browser/ui/stack_view/card_set.h:50: @property(weak, nonatomic,
readonly) CardStackLayoutManager* stackModel;
It seems like these four properties are all strong / might be replaced with just
methods to avoid confusion.

https://codereview.chromium.org/2944443003/diff/1/ios/chrome/browser/ui/stack...
File ios/chrome/browser/ui/stack_view/card_view.mm (right):

https://codereview.chromium.org/2944443003/diff/1/ios/chrome/browser/ui/stack...
ios/chrome/browser/ui/stack_view/card_view.mm:440: id _cardCloseTarget;  // weak
s/"// weak"//__weak

https://codereview.chromium.org/2944443003/diff/1/ios/chrome/browser/ui/stack...
ios/chrome/browser/ui/stack_view/card_view.mm:442: id _accessibilityTarget;  //
weak
ditto

[marq (ping after 24h), 2017-06-19 10:03:39]

Review feedback

[marq (ping after 24h), 2017-06-19 10:03:39]

The CQ bit was checked by marq@chromium.org

[marq (ping after 24h), 2017-06-19 10:03:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
stkhapugin@chromium.org
Link to the patchset: https://codereview.chromium.org/2944443003/#ps20001
(title: "Review feedback")

[commit-bot: I haz the power, 2017-06-19 10:03:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marq (ping after 24h), 2017-06-19 10:34:24]

Thanks for the review!

https://codereview.chromium.org/2944443003/diff/1/ios/chrome/browser/ui/stack...
File ios/chrome/browser/ui/stack_view/card_set.h (right):

https://codereview.chromium.org/2944443003/diff/1/ios/chrome/browser/ui/stack...
ios/chrome/browser/ui/stack_view/card_set.h:50: @property(weak, nonatomic,
readonly) CardStackLayoutManager* stackModel;
On 2017/06/16 13:17:50, stkhapugin wrote:
> It seems like these four properties are all strong / might be replaced with
just
> methods to avoid confusion. 

I'll make them not-weak, but I don't want to fiddle with the API.

https://codereview.chromium.org/2944443003/diff/1/ios/chrome/browser/ui/stack...
File ios/chrome/browser/ui/stack_view/card_view.mm (right):

https://codereview.chromium.org/2944443003/diff/1/ios/chrome/browser/ui/stack...
ios/chrome/browser/ui/stack_view/card_view.mm:440: id _cardCloseTarget;  // weak
On 2017/06/16 13:17:50, stkhapugin wrote:
> s/"// weak"//__weak

Done.

https://codereview.chromium.org/2944443003/diff/1/ios/chrome/browser/ui/stack...
ios/chrome/browser/ui/stack_view/card_view.mm:442: id _accessibilityTarget;  //
weak
On 2017/06/16 13:17:50, stkhapugin wrote:
> ditto

Done.

[commit-bot: I haz the power, 2017-06-19 11:29:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 11:29:32]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[marq (ping after 24h), 2017-06-19 15:55:28]

Rebased.

[marq (ping after 24h), 2017-06-19 15:59:28]

Remove debugging DCHECK.

[marq (ping after 24h), 2017-06-19 15:59:29]

The CQ bit was checked by marq@chromium.org

[marq (ping after 24h), 2017-06-19 15:59:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
stkhapugin@chromium.org
Link to the patchset: https://codereview.chromium.org/2944443003/#ps60001
(title: "Remove debugging DCHECK.")

[commit-bot: I haz the power, 2017-06-19 15:59:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 17:30:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 17:30:26]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[marq (ping after 24h), 2017-06-20 14:28:17]

PTAL at the changes to card_set and stack_view_controller.

[marq (ping after 24h), 2017-06-20 16:29:44]

The CQ bit was checked by marq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 16:30:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 18:28:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 18:28:45]

Dry run: This issue passed the CQ dry run.

[stkhapugin, 2017-06-21 11:35:00]

lgtm

[marq (ping after 24h), 2017-06-21 11:38:19]

The CQ bit was checked by marq@chromium.org

[commit-bot: I haz the power, 2017-06-21 11:38:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 11:51:27]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1498045099972460,
"parent_rev": "65f143da57bb9367c5004c659d368642bd9969f6", "commit_rev":
"6a9b847e0cbcfd1c8858a8fd63062221f5f96775"}

[commit-bot: I haz the power, 2017-06-21 11:51:41]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/ui/stack_view:stack_view to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/ui/stack_view:stack_view to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2944443003
Cr-Commit-Position: refs/heads/master@{#481177}
Committed:
https://chromium.googlesource.com/chromium/src/+/6a9b847e0cbcfd1c8858a8fd6306...
==========

[commit-bot: I haz the power, 2017-06-21 11:51:42]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/6a9b847e0cbcfd1c8858a8fd6306...