Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: ios/chrome/browser/metrics/BUILD.gn

Issue 2944443003: [ObjC ARC] Converts ios/chrome/browser/ui/stack_view:stack_view to ARC. (Closed)
Patch Set: Add and use explicit disconnect in CardSet. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/metrics/tab_usage_recorder.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 source_set("metrics") { 5 source_set("metrics") {
6 configs += [ "//build/config/compiler:enable_arc" ] 6 configs += [ "//build/config/compiler:enable_arc" ]
7 sources = [ 7 sources = [
8 "field_trial_synchronizer.cc", 8 "field_trial_synchronizer.cc",
9 "field_trial_synchronizer.h", 9 "field_trial_synchronizer.h",
10 "ios_chrome_metrics_service_accessor.cc", 10 "ios_chrome_metrics_service_accessor.cc",
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 source_set("metrics_internal") { 86 source_set("metrics_internal") {
87 configs += [ "//build/config/compiler:enable_arc" ] 87 configs += [ "//build/config/compiler:enable_arc" ]
88 sources = [ 88 sources = [
89 "first_user_action_recorder.cc", 89 "first_user_action_recorder.cc",
90 "first_user_action_recorder.h", 90 "first_user_action_recorder.h",
91 "new_tab_page_uma.h", 91 "new_tab_page_uma.h",
92 "new_tab_page_uma.mm", 92 "new_tab_page_uma.mm",
93 "size_class_recorder.h", 93 "size_class_recorder.h",
94 "size_class_recorder.mm", 94 "size_class_recorder.mm",
95 "size_class_recorder_private.h", 95 "size_class_recorder_private.h",
96 "tab_usage_recorder.h",
97 "tab_usage_recorder.mm",
98 "tab_usage_recorder_delegate.h", 96 "tab_usage_recorder_delegate.h",
99 ] 97 ]
100 deps = [ 98 deps = [
101 ":metrics", 99 ":metrics",
102 "//base", 100 "//base",
103 "//components/google/core/browser", 101 "//components/google/core/browser",
104 "//ios/chrome/browser", 102 "//ios/chrome/browser",
105 "//ios/chrome/browser/browser_state", 103 "//ios/chrome/browser/browser_state",
106 "//ios/chrome/browser/tabs", 104 "//ios/chrome/browser/tabs",
107 "//ios/chrome/browser/ui", 105 "//ios/chrome/browser/ui",
108 "//ios/web", 106 "//ios/web",
109 "//ui/base", 107 "//ui/base",
110 "//url", 108 "//url",
111 ] 109 ]
112 public_deps = [ 110 public_deps = [
113 ":metrics_internal_arc", 111 ":metrics_internal_arc",
112 ":metrics_internal_noarc",
114 ] 113 ]
115 allow_circular_includes_from = [ ":metrics_internal_arc" ] 114 allow_circular_includes_from = [
115 ":metrics_internal_arc",
116 ":metrics_internal_noarc",
117 ]
116 libs = [ "UIKit.framework" ] 118 libs = [ "UIKit.framework" ]
117 } 119 }
118 120
121 source_set("metrics_internal_noarc") {
122 # TODO(crbug.com/731724) This target shouldn't be compiled with ARC until
123 # after it's converted to use WebStates instead of Tabs.
124 cflags_objc = [ "-fno-objc-arc" ]
125
126 sources = [
127 "tab_usage_recorder.h",
128 "tab_usage_recorder.mm",
129 ]
130
131 deps = [
132 ":metrics",
133 "//base",
134 "//ios/chrome/browser",
135 "//ios/chrome/browser/tabs",
136 "//ios/web",
137 ]
138 }
139
119 source_set("metrics_internal_arc") { 140 source_set("metrics_internal_arc") {
120 sources = [ 141 sources = [
121 "tab_usage_recorder_web_state_list_observer.h", 142 "tab_usage_recorder_web_state_list_observer.h",
122 "tab_usage_recorder_web_state_list_observer.mm", 143 "tab_usage_recorder_web_state_list_observer.mm",
123 ] 144 ]
124 deps = [ 145 deps = [
146 ":metrics_internal_noarc",
125 "//base", 147 "//base",
126 "//ios/chrome/browser/tabs", 148 "//ios/chrome/browser/tabs",
127 "//ios/chrome/browser/web_state_list", 149 "//ios/chrome/browser/web_state_list",
128 ] 150 ]
129 configs += [ "//build/config/compiler:enable_arc" ] 151 configs += [ "//build/config/compiler:enable_arc" ]
130 } 152 }
131 153
132 source_set("unit_tests_internal") { 154 source_set("unit_tests_internal") {
133 configs += [ "//build/config/compiler:enable_arc" ] 155 configs += [ "//build/config/compiler:enable_arc" ]
134 testonly = true 156 testonly = true
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 "//ios/chrome/app/strings", 233 "//ios/chrome/app/strings",
212 "//ios/chrome/browser/ui", 234 "//ios/chrome/browser/ui",
213 "//ios/chrome/browser/ui/tools_menu", 235 "//ios/chrome/browser/ui/tools_menu",
214 "//ios/chrome/test/app:test_support", 236 "//ios/chrome/test/app:test_support",
215 "//ios/chrome/test/earl_grey:test_support", 237 "//ios/chrome/test/earl_grey:test_support",
216 "//ios/testing:ios_test_support", 238 "//ios/testing:ios_test_support",
217 "//ui/base", 239 "//ui/base",
218 ] 240 ]
219 configs += [ "//build/config/compiler:enable_arc" ] 241 configs += [ "//build/config/compiler:enable_arc" ]
220 } 242 }
OLDNEW
« no previous file with comments | « no previous file | ios/chrome/browser/metrics/tab_usage_recorder.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698