Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: ios/chrome/browser/ui/stack_view/close_button.mm

Issue 2944443003: [ObjC ARC] Converts ios/chrome/browser/ui/stack_view:stack_view to ARC. (Closed)
Patch Set: Add and use explicit disconnect in CardSet. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/stack_view/close_button.mm
diff --git a/ios/chrome/browser/ui/stack_view/close_button.mm b/ios/chrome/browser/ui/stack_view/close_button.mm
index 45ff4f353afa49a7efd4198321591db427ca9f34..c272c305ed31b77632ab58f9ddbc899ac52ec0d3 100644
--- a/ios/chrome/browser/ui/stack_view/close_button.mm
+++ b/ios/chrome/browser/ui/stack_view/close_button.mm
@@ -6,8 +6,12 @@
#include "base/logging.h"
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
@implementation CloseButton {
- id _accessibilityTarget; // weak
+ __weak id _accessibilityTarget;
SEL _accessibilityAction;
}
@@ -20,7 +24,10 @@
}
- (void)accessibilityElementDidBecomeFocused {
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Warc-performSelector-leaks"
[_accessibilityTarget performSelector:_accessibilityAction withObject:self];
+#pragma clang diagnostic pop
}
@end
« no previous file with comments | « ios/chrome/browser/ui/stack_view/card_view.mm ('k') | ios/chrome/browser/ui/stack_view/page_animation_util.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698