Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: ios/chrome/browser/ui/stack_view/stack_view_controller_private.h

Issue 2944443003: [ObjC ARC] Converts ios/chrome/browser/ui/stack_view:stack_view to ARC. (Closed)
Patch Set: Add and use explicit disconnect in CardSet. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/stack_view/stack_view_controller_private.h
diff --git a/ios/chrome/browser/ui/stack_view/stack_view_controller_private.h b/ios/chrome/browser/ui/stack_view/stack_view_controller_private.h
index 0bdbdf1c7e82d0d42b9d130b9d676faff4cbc309..fc01b99f912f4797da37b8f07aa312fa7ce29826 100644
--- a/ios/chrome/browser/ui/stack_view/stack_view_controller_private.h
+++ b/ios/chrome/browser/ui/stack_view/stack_view_controller_private.h
@@ -68,7 +68,7 @@ typedef enum {
- (CGRect)inactiveDeckRegion;
// The currently active card set.
-@property(nonatomic, readonly) CardSet* activeCardSet;
+@property(nonatomic, weak, readonly) CardSet* activeCardSet;
// The current transition style.
@property(nonatomic, assign) StackTransitionStyle transitionStyle;
@@ -78,13 +78,13 @@ typedef enum {
@property(nonatomic, assign) BOOL transitionWasCancelled;
// The owner of |transitionToolbarController|.
-@property(nonatomic, retain) id<ToolbarOwner> transitionToolbarOwner;
+@property(nonatomic, strong) id<ToolbarOwner> transitionToolbarOwner;
// The toolbar controller used in transition animations.
-@property(nonatomic, retain) ToolbarController* transitionToolbarController;
+@property(nonatomic, strong) ToolbarController* transitionToolbarController;
// The dummy view used in the transition animation.
-@property(nonatomic, retain) UIView* dummyToolbarBackgroundView;
+@property(nonatomic, strong) UIView* dummyToolbarBackgroundView;
// The cached frame of the transition toolbar's frame.
@property(nonatomic, assign) CGRect transitionToolbarFrame;
@@ -92,7 +92,7 @@ typedef enum {
// Records which card was tapped mid-presentation animation, if any.
// TODO(crbug.com/546209): Implement reversed animations for dismissing with a
// new selected card mid-presentation.
-@property(nonatomic, retain) StackCard* transitionTappedCard;
+@property(nonatomic, strong) StackCard* transitionTappedCard;
// |YES| if there is card set animation being processed.
@property(nonatomic, readonly) BOOL inActiveDeckChangeAnimation;

Powered by Google App Engine
This is Rietveld 408576698