[CSS Typed OM] Add missing error handling for CSSRotation constructor

[CSS Typed OM] Add missing error handling for CSSRotation constructor

Note: breaks current is2D handling, but it isn't consistent with the 
spec right now anyway (https://drafts.css-houdini.org/css-typed-om/#dom-csstransformcomponent-is2d)

BUG=545318
Review-Url: https://codereview.chromium.org/2938353002
Cr-Commit-Position: refs/heads/master@{#481455}
Committed: https://chromium.googlesource.com/chromium/src/+/c736555ad42dd36b986506e05bc532529bf5f808

[meade_UTC10, 2017-06-16 06:26:54]

meade@chromium.org changed reviewers:
+ shend@chromium.org

[meade_UTC10, 2017-06-16 06:26:55]

Hi shend, PTAL

[shend, 2017-06-16 06:30:13]

lgtm

[meade_UTC10, 2017-06-16 06:31:45]

The CQ bit was checked by meade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 06:32:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 07:49:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 07:49:01]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[alancutter (OOO until 2018), 2017-06-19 04:13:03]

alancutter@chromium.org changed reviewers:
+ alancutter@chromium.org

[alancutter (OOO until 2018), 2017-06-19 04:13:04]

https://codereview.chromium.org/2938353002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/typedcssom/cssRotation-expected.txt (right):

https://codereview.chromium.org/2938353002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/typedcssom/cssRotation-expected.txt:15: FAIL is2D
value is correct for rotate(3.2deg) assert_equals: expected true but got false
Why are these expected to fail?

[meade_UTC10, 2017-06-19 07:54:46]

Description was changed from

==========
[CSS Typed OM] Add missing error handling for CSSRotation constructor

BUG=545318
==========

to

==========
[CSS Typed OM] Add missing error handling for CSSRotation constructor

Note: breaks current is2D handling, but it isn't consistent with the 
spec right now anyway
(https://drafts.css-houdini.org/css-typed-om/#dom-csstransformcomponent-is2d)

BUG=545318
==========

[meade_UTC10, 2017-06-19 07:55:07]

https://codereview.chromium.org/2938353002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/typedcssom/cssRotation-expected.txt (right):

https://codereview.chromium.org/2938353002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/typedcssom/cssRotation-expected.txt:15: FAIL is2D
value is correct for rotate(3.2deg) assert_equals: expected true but got false
On 2017/06/19 04:13:04, alancutter wrote:
> Why are these expected to fail?

They're not particularly, but I'm re-writing is2D handling in a future patch
(obv WIP: https://codereview.chromium.org/2943303002/) so I decided I didn't
mind if I broke it a bit in the mean time.

[meade_UTC10, 2017-06-19 08:00:04]

The CQ bit was checked by meade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-19 08:00:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 09:37:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 09:37:54]

Dry run: This issue passed the CQ dry run.

[meade_UTC10, 2017-06-19 10:06:03]

The CQ bit was checked by meade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-19 10:06:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 10:13:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 10:13:48]

Dry run: This issue passed the CQ dry run.

[alancutter (OOO until 2018), 2017-06-19 10:51:28]

https://codereview.chromium.org/2938353002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/CSSRotation.h (right):

https://codereview.chromium.org/2938353002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/CSSRotation.h:41: CSSNumericValue*
angle);
I don't think we should add these if we never use them. ExceptionStates aren't a
very big dependency for Blink internally anyway.

[meade_UTC10, 2017-06-21 07:11:30]

https://codereview.chromium.org/2938353002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/CSSRotation.h (right):

https://codereview.chromium.org/2938353002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/CSSRotation.h:41: CSSNumericValue*
angle);
On 2017/06/19 10:51:27, alancutter wrote:
> I don't think we should add these if we never use them. ExceptionStates aren't
a
> very big dependency for Blink internally anyway.

This existed before (I actually added the exception state ones in this CL, not
the non-exception state ones, but the diff is weird).

It's also used in a function in an anonymous namespace inside CSSRotation.cpp. I
could refactor everything to make it private if you really want, but I'd want to
change this style in all the other transform components as well, in a separate
CL.

[alancutter (OOO until 2018), 2017-06-22 03:12:12]

lgtm

https://codereview.chromium.org/2938353002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/CSSRotation.h (right):

https://codereview.chromium.org/2938353002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/CSSRotation.h:41: CSSNumericValue*
angle);
On 2017/06/21 at 07:11:30, meade_UTC10 wrote:
> On 2017/06/19 10:51:27, alancutter wrote:
> > I don't think we should add these if we never use them. ExceptionStates
aren't a
> > very big dependency for Blink internally anyway.
> 
> This existed before (I actually added the exception state ones in this CL, not
the non-exception state ones, but the diff is weird).
> 
> It's also used in a function in an anonymous namespace inside CSSRotation.cpp.
I could refactor everything to make it private if you really want, but I'd want
to change this style in all the other transform components as well, in a
separate CL.

My mistake, didn't realise they were used.

[meade_UTC10, 2017-06-22 03:30:00]

The CQ bit was checked by meade@chromium.org

[meade_UTC10, 2017-06-22 03:30:00]

The patchset sent to the CQ was uploaded after l-g-t-m from shend@chromium.org
Link to the patchset: https://codereview.chromium.org/2938353002/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2017-06-22 03:30:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 05:46:45]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1498102200108110,
"parent_rev": "66abd3b2a93a32f28727b4cb734cc04ec49d6443", "commit_rev":
"c736555ad42dd36b986506e05bc532529bf5f808"}

[commit-bot: I haz the power, 2017-06-22 05:46:57]

Description was changed from

==========
[CSS Typed OM] Add missing error handling for CSSRotation constructor

Note: breaks current is2D handling, but it isn't consistent with the 
spec right now anyway
(https://drafts.css-houdini.org/css-typed-om/#dom-csstransformcomponent-is2d)

BUG=545318
==========

to

==========
[CSS Typed OM] Add missing error handling for CSSRotation constructor

Note: breaks current is2D handling, but it isn't consistent with the 
spec right now anyway
(https://drafts.css-houdini.org/css-typed-om/#dom-csstransformcomponent-is2d)

BUG=545318

Review-Url: https://codereview.chromium.org/2938353002
Cr-Commit-Position: refs/heads/master@{#481455}
Committed:
https://chromium.googlesource.com/chromium/src/+/c736555ad42dd36b986506e05bc5...
==========

[commit-bot: I haz the power, 2017-06-22 05:46:58]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/c736555ad42dd36b986506e05bc5...