[CSS Typed OM] Add missing error handling for CSSRotation constructor

third_party/WebKit/Source/core/css/cssom/CSSRotation.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CSSRotation_h
 #define CSSRotation_h
 
 #include "core/css/cssom/CSSNumericValue.h"
 #include "core/css/cssom/CSSTransformComponent.h"
 
 namespace blink {
 
 class DOMMatrix;
 
 // Represents a rotation value in a CSSTransformValue used for properties like
 // "transform".
 // See CSSRotation.idl for more information about this class.
 class CORE_EXPORT CSSRotation final : public CSSTransformComponent {
   WTF_MAKE_NONCOPYABLE(CSSRotation);
   DEFINE_WRAPPERTYPEINFO();
 
  public:
   // Constructors defined in the IDL.
-  static CSSRotation* Create(const CSSNumericValue* angle_value) {
-    return new CSSRotation(angle_value);
+  static CSSRotation* Create(CSSNumericValue* angle,
+                             ExceptionState& exception_state) {
+    return Create(0, 0, 1, angle, exception_state);
   }
   static CSSRotation* Create(double x,
                              double y,
                              double z,
-                             const CSSNumericValue* angle_value) {
-    return new CSSRotation(x, y, z, angle_value);
-  }
+                             CSSNumericValue* angle,
+                             ExceptionState&);
 
   // Blink-internal ways of creating CSSRotations.
+  static CSSRotation* Create(CSSNumericValue* angle) {
+    return Create(0, 0, 1, angle);
+  }
+  static CSSRotation* Create(double x,
+                             double y,
+                             double z,
+                             CSSNumericValue* angle);

[alancutter (OOO until 2018), 2017/06/19 10:51:27]

I don't think we should add these if we never use them. ExceptionStates aren't a
very big dependency for Blink internally anyway.

[meade_UTC10, 2017/06/21 07:11:30]

This existed before (I actually added the exception state ones in this CL, not
the non-exception state ones, but the diff is weird).

It's also used in a function in an anonymous namespace inside CSSRotation.cpp. I
could refactor everything to make it private if you really want, but I'd want to
change this style in all the other transform components as well, in a separate
CL.

[alancutter (OOO until 2018), 2017/06/22 03:12:12]

My mistake, didn't realise they were used.

   static CSSRotation* FromCSSValue(const CSSFunctionValue&);
 
   // Getters and setters for attributes defined in the IDL.
   // Bindings requires returning non-const pointers. This is safe because
   // CSSNumericValues are immutable.
   CSSNumericValue* angle() const {
     return const_cast<CSSNumericValue*>(angle_.Get());
   }
   double x() const { return x_; }
   double y() const { return y_; }
@@ skipping 30 matching lines @@
   Member<const CSSNumericValue> angle_;
   double x_;
   double y_;
   double z_;
   bool is2d_;
 };
 
 }  // namespace blink
 
 #endif