[CSS Typed OM] Make CSSRotation attributes mutable.

[CSS Typed OM] Make CSSRotation attributes mutable.

Spec: https://drafts.css-houdini.org/css-typed-om/#cssrotation

This CL also removes the "is2d_" member of CSSRotation to make way
for a future refactor for updated handling of "2D-ness" of 
CSSTransformComponents (WIP here:
https://codereview.chromium.org/2943303002/
For now, some is2D tests will fail, but it's not worth fixing them
in light of the future refactor.

BUG=545318
Review-Url: https://codereview.chromium.org/2942183002
Cr-Commit-Position: refs/heads/master@{#482933}
Committed: https://chromium.googlesource.com/chromium/src/+/5655311243673c93bc6f402206a3feff0d1d78b5

[meade_UTC10, 2017-06-16 07:06:44]

The CQ bit was checked by meade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 07:07:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[meade_UTC10, 2017-06-16 07:08:05]

meade@chromium.org changed reviewers:
+ bugsnash@chromium.org

[commit-bot: I haz the power, 2017-06-16 07:09:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 07:09:46]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Bugs Nash, 2017-06-18 23:12:56]

lgtm, but I am not familiar with cssom code

please add to the description:
- removal of is2d attribute
- why new failure expectation has been added to cssRotation test

[meade_UTC10, 2017-06-19 08:02:36]

Description was changed from

==========
[CSS Typed OM] Make CSSRotation attributes mutable.

Spec: https://drafts.css-houdini.org/css-typed-om/#cssrotation

BUG=545318
==========

to

==========
[CSS Typed OM] Make CSSRotation attributes mutable.

Spec: https://drafts.css-houdini.org/css-typed-om/#cssrotation

This CL also removes the "is2d_" member of CSSRotation to make way
for a future refactor for updated handling of "2D-ness" of 
CSSTransformComponents (WIP here:
https://codereview.chromium.org/2943303002/

BUG=545318
==========

[meade_UTC10, 2017-06-19 08:03:39]

Description was changed from

==========
[CSS Typed OM] Make CSSRotation attributes mutable.

Spec: https://drafts.css-houdini.org/css-typed-om/#cssrotation

This CL also removes the "is2d_" member of CSSRotation to make way
for a future refactor for updated handling of "2D-ness" of 
CSSTransformComponents (WIP here:
https://codereview.chromium.org/2943303002/

BUG=545318
==========

to

==========
[CSS Typed OM] Make CSSRotation attributes mutable.

Spec: https://drafts.css-houdini.org/css-typed-om/#cssrotation

This CL also removes the "is2d_" member of CSSRotation to make way
for a future refactor for updated handling of "2D-ness" of 
CSSTransformComponents (WIP here:
https://codereview.chromium.org/2943303002/
For now, some is2D tests will fail, but it's not worth fixing them
in light of the future refactor.

BUG=545318
==========

[meade_UTC10, 2017-06-19 08:04:01]

On 2017/06/18 23:12:56, Bugs Nash wrote:
> lgtm, but I am not familiar with cssom code
> 
> please add to the description:
> - removal of is2d attribute
> - why new failure expectation has been added to cssRotation test

Done, Thanks!

[meade_UTC10, 2017-06-22 06:47:33]

The CQ bit was checked by meade@chromium.org

[meade_UTC10, 2017-06-22 06:47:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
bugsnash@chromium.org
Link to the patchset: https://codereview.chromium.org/2942183002/#ps80001
(title: "remove const")

[commit-bot: I haz the power, 2017-06-22 06:47:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 07:06:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 07:06:45]

Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[meade_UTC10, 2017-06-23 03:16:37]

Patchset #6 (id:100001) has been deleted

[meade_UTC10, 2017-06-23 03:19:14]

The CQ bit was checked by meade@chromium.org

[meade_UTC10, 2017-06-23 03:19:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
bugsnash@chromium.org
Link to the patchset: https://codereview.chromium.org/2942183002/#ps70006
(title: "Add global interface expectations")

[commit-bot: I haz the power, 2017-06-23 03:19:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 03:35:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-23 03:35:19]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[meade_UTC10, 2017-06-23 03:42:59]

The CQ bit was checked by meade@chromium.org

[commit-bot: I haz the power, 2017-06-23 03:43:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 03:56:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-23 03:56:47]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[meade_UTC10, 2017-06-23 09:08:02]

The CQ bit was checked by meade@chromium.org

[commit-bot: I haz the power, 2017-06-23 09:08:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 09:24:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-23 09:24:44]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[meade_UTC10, 2017-06-23 09:26:45]

The CQ bit was checked by meade@chromium.org

[commit-bot: I haz the power, 2017-06-23 09:26:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 09:44:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-23 09:44:05]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[meade_UTC10, 2017-06-28 07:53:11]

The CQ bit was checked by meade@chromium.org

[meade_UTC10, 2017-06-28 07:53:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
bugsnash@chromium.org
Link to the patchset: https://codereview.chromium.org/2942183002/#ps150001
(title: "rebase")

[commit-bot: I haz the power, 2017-06-28 07:53:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 10:09:10]

CQ is committing da patch.

Bot data: {"patchset_id": 150001, "attempt_start_ts": 1498636391390900,
"parent_rev": "a703ff1bc9db59827740a249bdcbbf8c6e8c1f1c", "commit_rev":
"5655311243673c93bc6f402206a3feff0d1d78b5"}

[commit-bot: I haz the power, 2017-06-28 10:09:24]

Description was changed from

==========
[CSS Typed OM] Make CSSRotation attributes mutable.

Spec: https://drafts.css-houdini.org/css-typed-om/#cssrotation

This CL also removes the "is2d_" member of CSSRotation to make way
for a future refactor for updated handling of "2D-ness" of 
CSSTransformComponents (WIP here:
https://codereview.chromium.org/2943303002/
For now, some is2D tests will fail, but it's not worth fixing them
in light of the future refactor.

BUG=545318
==========

to

==========
[CSS Typed OM] Make CSSRotation attributes mutable.

Spec: https://drafts.css-houdini.org/css-typed-om/#cssrotation

This CL also removes the "is2d_" member of CSSRotation to make way
for a future refactor for updated handling of "2D-ness" of 
CSSTransformComponents (WIP here:
https://codereview.chromium.org/2943303002/
For now, some is2D tests will fail, but it's not worth fixing them
in light of the future refactor.

BUG=545318

Review-Url: https://codereview.chromium.org/2942183002
Cr-Commit-Position: refs/heads/master@{#482933}
Committed:
https://chromium.googlesource.com/chromium/src/+/5655311243673c93bc6f402206a3...
==========

[commit-bot: I haz the power, 2017-06-28 10:09:25]

Committed patchset #8 (id:150001) as
https://chromium.googlesource.com/chromium/src/+/5655311243673c93bc6f402206a3...