[CSS Typed OM] Add missing error handling for CSSRotation constructor

third_party/WebKit/Source/core/css/cssom/CSSRotation.h

Index: third_party/WebKit/Source/core/css/cssom/CSSRotation.h
diff --git a/third_party/WebKit/Source/core/css/cssom/CSSRotation.h b/third_party/WebKit/Source/core/css/cssom/CSSRotation.h
index 0e8b6d598bbde69659d7b134df45f441ed4f7572..e4e0809e520f3f7b35d2b8508f16a853e0fcff33 100644
--- a/third_party/WebKit/Source/core/css/cssom/CSSRotation.h
+++ b/third_party/WebKit/Source/core/css/cssom/CSSRotation.h
@@ -21,17 +21,24 @@ class CORE_EXPORT CSSRotation final : public CSSTransformComponent {
 
  public:
   // Constructors defined in the IDL.
-  static CSSRotation* Create(const CSSNumericValue* angle_value) {
-    return new CSSRotation(angle_value);
+  static CSSRotation* Create(CSSNumericValue* angle,
+                             ExceptionState& exception_state) {
+    return Create(0, 0, 1, angle, exception_state);
   }
   static CSSRotation* Create(double x,
                              double y,
                              double z,
-                             const CSSNumericValue* angle_value) {
-    return new CSSRotation(x, y, z, angle_value);
-  }
+                             CSSNumericValue* angle,
+                             ExceptionState&);
 
   // Blink-internal ways of creating CSSRotations.
+  static CSSRotation* Create(CSSNumericValue* angle) {
+    return Create(0, 0, 1, angle);
+  }
+  static CSSRotation* Create(double x,
+                             double y,
+                             double z,
+                             CSSNumericValue* angle);

[alancutter (OOO until 2018), 2017/06/19 10:51:27]

I don't think we should add these if we never use them. ExceptionStates aren't a
very big dependency for Blink internally anyway.

[meade_UTC10, 2017/06/21 07:11:30]

This existed before (I actually added the exception state ones in this CL, not
the non-exception state ones, but the diff is weird).

It's also used in a function in an anonymous namespace inside CSSRotation.cpp. I
could refactor everything to make it private if you really want, but I'd want to
change this style in all the other transform components as well, in a separate
CL.

[alancutter (OOO until 2018), 2017/06/22 03:12:12]

My mistake, didn't realise they were used.

   static CSSRotation* FromCSSValue(const CSSFunctionValue&);
 
   // Getters and setters for attributes defined in the IDL.