Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2931953002: [Payments] Rename openWindowForClients and openWindowForPaymentHandler (Closed)

Created:
3 years, 6 months ago by gogerald1
Modified:
3 years, 6 months ago
Reviewers:
falken, pfeldman, dcheng
CC:
chromium-reviews, michaeln, mlamouri+watch-content_chromium.org, tzik, jsbell+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org, blink-reviews, darin-cc_chromium.org, kinuko+watch, shimazu+serviceworker_chromium.org, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org, platform-architecture-syd+reviews-web_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename openWindowForClients and openWindowForPaymentHandler This is for the comments after landing this CL https://codereview.chromium.org/2893823004/ from dcheng@. BUG=661608 Review-Url: https://codereview.chromium.org/2931953002 Cr-Commit-Position: refs/heads/master@{#478183} Committed: https://chromium.googlesource.com/chromium/src/+/f3bc2120d3a8276002d52fcb0d18bf6066ee96a7

Patch Set 1 #

Total comments: 2

Patch Set 2 : address nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -17 lines) Patch
M content/renderer/service_worker/service_worker_context_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp View 1 chunk +4 lines, -6 lines 0 comments Download
M third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h View 1 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
gogerald1
Hi pfeldman@ and dcheng@, ptal,
3 years, 6 months ago (2017-06-08 20:36:40 UTC) #5
dcheng
LGTM, thanks! https://codereview.chromium.org/2931953002/diff/1/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h File third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h (right): https://codereview.chromium.org/2931953002/diff/1/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h#newcode278 third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h:278: // Similar like OpenNewTab above. Nit: Similar ...
3 years, 6 months ago (2017-06-08 20:43:55 UTC) #6
falken
service worker lgtm
3 years, 6 months ago (2017-06-09 01:47:25 UTC) #10
gogerald1
Thanks, sending to CQ, https://codereview.chromium.org/2931953002/diff/1/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h File third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h (right): https://codereview.chromium.org/2931953002/diff/1/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h#newcode278 third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h:278: // Similar like OpenNewTab above. ...
3 years, 6 months ago (2017-06-09 01:52:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2931953002/20001
3 years, 6 months ago (2017-06-09 01:53:11 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 03:31:49 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f3bc2120d3a8276002d52fcb0d18...

Powered by Google App Engine
This is Rietveld 408576698