third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp - Issue 2931953002: [Payments] Rename openWindowForClients and openWindowForPaymentHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

Issue 2931953002: [Payments] Rename openWindowForClients and openWindowForPaymentHandler (Closed)

Patch Set: address nit Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/service_worker/service_worker_context_client.cc ('k') | third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

index 00e1a649891f7ba3547314d3a5e6c9d4222666a5..b7d7dc8e4ec6c70fa1a758e23eedeee6a6a65d0d 100644

--- a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

+++ b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

@@ -62,13 +62,13 @@ void ServiceWorkerGlobalScopeClientImpl::GetClients(

void ServiceWorkerGlobalScopeClientImpl::OpenWindowForClients(

const WebURL& url,

std::unique_ptr<WebServiceWorkerClientCallbacks> callbacks) {

- client_.OpenWindowForClients(url, std::move(callbacks));

+ client_.OpenNewTab(url, std::move(callbacks));

}

void ServiceWorkerGlobalScopeClientImpl::OpenWindowForPaymentHandler(

const WebURL& url,

std::unique_ptr<WebServiceWorkerClientCallbacks> callbacks) {

- client_.OpenWindowForPaymentHandler(url, std::move(callbacks));

+ client_.OpenNewPopup(url, std::move(callbacks));

}

void ServiceWorkerGlobalScopeClientImpl::SetCachedMetadata(const WebURL& url,