Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1704)

Unified Diff: content/renderer/service_worker/service_worker_context_client.cc

Issue 2931953002: [Payments] Rename openWindowForClients and openWindowForPaymentHandler (Closed)
Patch Set: address nit Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/service_worker_context_client.cc
diff --git a/content/renderer/service_worker/service_worker_context_client.cc b/content/renderer/service_worker/service_worker_context_client.cc
index a34228165a1af801f7bab40cce382b34f8e7f3e1..60821cc41360dee0f721d75a029affa6f6a55120 100644
--- a/content/renderer/service_worker/service_worker_context_client.cc
+++ b/content/renderer/service_worker/service_worker_context_client.cc
@@ -631,7 +631,7 @@ void ServiceWorkerContextClient::GetClients(
GetRoutingID(), request_id, options));
}
-void ServiceWorkerContextClient::OpenWindowForClients(
+void ServiceWorkerContextClient::OpenNewTab(
const blink::WebURL& url,
std::unique_ptr<blink::WebServiceWorkerClientCallbacks> callbacks) {
DCHECK(callbacks);
@@ -639,7 +639,7 @@ void ServiceWorkerContextClient::OpenWindowForClients(
Send(new ServiceWorkerHostMsg_OpenNewTab(GetRoutingID(), request_id, url));
}
-void ServiceWorkerContextClient::OpenWindowForPaymentHandler(
+void ServiceWorkerContextClient::OpenNewPopup(
const blink::WebURL& url,
std::unique_ptr<blink::WebServiceWorkerClientCallbacks> callbacks) {
DCHECK(callbacks);

Powered by Google App Engine
This is Rietveld 408576698