content/renderer/service_worker/service_worker_context_client.h - Issue 2931953002: [Payments] Rename openWindowForClients and openWindowForPaymentHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/service_worker/service_worker_context_client.h

Issue 2931953002: [Payments] Rename openWindowForClients and openWindowForPaymentHandler (Closed)

Patch Set: address nit Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/service_worker/service_worker_context_client.h

diff --git a/content/renderer/service_worker/service_worker_context_client.h b/content/renderer/service_worker/service_worker_context_client.h

index 12aacbf61fa6a54ed97c6151f33b0de083414373..5b5cac9d8306369ff8fd6c724e50ea4bfe51060a 100644

--- a/content/renderer/service_worker/service_worker_context_client.h

+++ b/content/renderer/service_worker/service_worker_context_client.h

@@ -102,10 +102,10 @@ class ServiceWorkerContextClient : public blink::WebServiceWorkerContextClient,

void GetClients(

const blink::WebServiceWorkerClientQueryOptions&,

std::unique_ptr<blink::WebServiceWorkerClientsCallbacks>) override;

- void OpenWindowForClients(

+ void OpenNewTab(

const blink::WebURL&,

std::unique_ptr<blink::WebServiceWorkerClientCallbacks>) override;

- void OpenWindowForPaymentHandler(

+ void OpenNewPopup(

const blink::WebURL&,

std::unique_ptr<blink::WebServiceWorkerClientCallbacks>) override;

void SetCachedMetadata(const blink::WebURL&,

« no previous file with comments | « no previous file | content/renderer/service_worker/service_worker_context_client.cc » ('j') | no next file with comments »